introduce rapids-generate-pip-constraints#114
introduce rapids-generate-pip-constraints#114jameslamb merged 4 commits intorapidsai:mainfrom jameslamb:rapids-constraints
Conversation
seberg
left a comment
There was a problem hiding this comment.
LGTM, nice. Also nice touch to add an error to the if!
|
@jameslamb could you put up a PR updating some repo (e.g. cudf) to use this tool? Cloning this branch in the CI of that repo and updating PATH should allow you to test the new tool. |
I put up rapidsai/cudf#17131 doing that. It looks like it's doing what we want.
@vyasr @seberg is that convincing? Want to merge this and then use it for the rest of rapidsai/build-planning#81? |
|
🎉 alright great, thanks everyone! I'll merge this and go apply it to |
…CI (#17131) Follow-up to #16570 (comment) Proposes using the new `rapids-generate-pip-constraints` tool from `gha-tools` to generate a list of pip constraints pinning to the oldest supported verisons of dependencies here. ## Notes for Reviewers ### How I tested this rapidsai/gha-tools#114 (comment) You can also see one the most recent `wheel-tests-cudf` builds here: * oldest-deps: numpy 1.x ([build link](https://github.com/rapidsai/cudf/actions/runs/11615430314/job/32347576688?pr=17131)) * latest-deps: numpy 2.x ([build link](https://github.com/rapidsai/cudf/actions/runs/11615430314/job/32347577095?pr=17131)) # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #17131
…CI (#1716) Follow-up to #1613 Similar to rapidsai/cudf#17131 Proposes using the new `rapids-generate-pip-constraints` tool from `gha-tools` to generate a list of pip constraints pinning to the oldest supported verisons of dependencies here. ## Notes for Reviewers ### How I tested this `wheel-tests`: * oldest-deps: numpy 1.x ([build link](https://github.com/rapidsai/rmm/actions/runs/11620907528/job/32364032641?pr=1716#step:8:106)) * latest-deps: numpy 2.x ([build link](https://github.com/rapidsai/rmm/actions/runs/11620907528/job/32364032835?pr=1716#step:8:104)) And the testing of the general approach in rapidsai/gha-tools#114 (comment) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1716
Contributes to rapidsai/build-planning#81
rapidsai/shared-workflows#228 introduced a new environment variable for wheel-testing CI jobs,
RAPIDS_DEPENDENCIES, which takes the following values:oldest= pin to oldest-supported versionslatest= do not constraint versionsTo take advantage of that in CI, PRs like rapidsai/cudf#16570 have been rolling out. They're all taking a similar approach, copying around the same snippet of code that generates a pip
constraints.txtfile usingrapids-dependency-file-generator.Based on the suggestion from rapidsai/cudf#16570 (comment), this proposes wrapping that behavior in a tool.
Notes for Reviewers
Benefits of this change
Simplifies and standardizes CI scripts.
Reduces the effort to roll out other types of testing with alternative dependency sets in the future.
How I tested this
With latest
cudf(including the changes from rapidsai/cudf#16570) checked out, ran the following from the root of that repo: