Skip to content

use rapids-generate-pip-constraints to pin to oldest dependencies in CI#17131

Merged
rapids-bot[bot] merged 9 commits intorapidsai:branch-24.12from
jameslamb:deps-tools
Oct 31, 2024
Merged

use rapids-generate-pip-constraints to pin to oldest dependencies in CI#17131
rapids-bot[bot] merged 9 commits intorapidsai:branch-24.12from
jameslamb:deps-tools

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Oct 18, 2024

Description

Follow-up to #16570 (comment)

Proposes using the new rapids-generate-pip-constraints tool from gha-tools to generate a list of pip constraints pinning to the oldest supported verisons of dependencies here.

Notes for Reviewers

How I tested this

rapidsai/gha-tools#114 (comment)

You can also see one the most recent wheel-tests-cudf builds here:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added 2 - In Progress Currently a work in progress DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 18, 2024
@jameslamb jameslamb removed 2 - In Progress Currently a work in progress DO NOT MERGE Hold off on merging; see PR for details labels Oct 31, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] use rapids-generate-pip-constraints to pin to oldest dependencies in CI use rapids-generate-pip-constraints to pin to oldest dependencies in CI Oct 31, 2024
@jameslamb jameslamb requested review from mroeschke and vyasr October 31, 2024 22:14
@jameslamb jameslamb marked this pull request as ready for review October 31, 2024 22:14
@jameslamb jameslamb requested a review from a team as a code owner October 31, 2024 22:14
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit b5b47fe into rapidsai:branch-24.12 Oct 31, 2024
@jameslamb jameslamb deleted the deps-tools branch October 31, 2024 22:31
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this pull request Nov 7, 2024
…CI (#1716)

Follow-up to #1613

Similar to rapidsai/cudf#17131

Proposes using the new `rapids-generate-pip-constraints` tool from `gha-tools` to generate a list of pip constraints pinning to the oldest supported verisons of dependencies here.

## Notes for Reviewers

### How I tested this

`wheel-tests`:

* oldest-deps: numpy 1.x ([build link](https://github.com/rapidsai/rmm/actions/runs/11620907528/job/32364032641?pr=1716#step:8:106))
* latest-deps: numpy 2.x ([build link](https://github.com/rapidsai/rmm/actions/runs/11620907528/job/32364032835?pr=1716#step:8:104))

And the testing of the general approach in rapidsai/gha-tools#114 (comment)

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #1716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants