Skip to content

[REVIEW] Pin dask & distributed for release #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
May 26, 2022
Merged

[REVIEW] Pin dask & distributed for release #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c799fd
pin dask for release
galipremsagar May 25, 2022
be67173
Update build.sh
galipremsagar May 25, 2022
d973e8c
Apply suggestions from code review
galipremsagar May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ci/gpu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ export NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=1

# Install dask and distributed from main branch. Usually needed during
# development time and disabled before a new dask-cuda release.
export INSTALL_DASK_MAIN=1
export INSTALL_DASK_MAIN=0

# Dask version to install when `INSTALL_DASK_MAIN=0`
export DASK_STABLE_VERSION="2022.05.1"

################################################################################
# SETUP - Check environment
Expand Down Expand Up @@ -71,8 +74,12 @@ if [[ "${INSTALL_DASK_MAIN}" == 1 ]]; then
gpuci_mamba_retry install -c dask/label/dev \
"dask/label/dev::dask" \
"dask/label/dev::distributed"
else
gpuci_logger "gpuci_mamba_retry install conda-forge::dask==${DASK_STABLE_VERSION} conda-forge::distributed==${DASK_STABLE_VERSION} conda-forge::dask-core==${DASK_STABLE_VERSION} --force-reinstall"
gpuci_mamba_retry install conda-forge::dask==${DASK_STABLE_VERSION} conda-forge::distributed==${DASK_STABLE_VERSION} conda-forge::dask-core==${DASK_STABLE_VERSION} --force-reinstall
fi


gpuci_logger "Check versions"
python --version
$CC --version
Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dask>=2022.03.0
distributed>=2022.03.0
dask==2022.05.1
distributed==2022.05.1
Comment on lines -1 to +2
Copy link
Member

@jakirkham jakirkham May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will ensure dask & distributed are pinned correctly in the Conda packages. In PR ( #893 ), we ensure these are pulled into the Conda packages

pynvml>=11.0.0
numpy>=1.16.0
numba>=0.54
Expand Down