Skip to content

Doc updates#516

Merged
raydouglass merged 5 commits into
rapidsai:branch-23.08from
AjayThorve:doc-updates
Aug 4, 2023
Merged

Doc updates#516
raydouglass merged 5 commits into
rapidsai:branch-23.08from
AjayThorve:doc-updates

Conversation

@AjayThorve
Copy link
Copy Markdown
Member

@AjayThorve AjayThorve commented Aug 4, 2023

Follow up to #494, updates API docs and screenshots.

cc @exactlyallan

@AjayThorve AjayThorve added doc Documentation non-breaking Non-breaking change labels Aug 4, 2023
@AjayThorve AjayThorve requested review from a team as code owners August 4, 2023 04:24
@review-notebook-app
Copy link
Copy Markdown

review-notebook-app Bot commented Aug 4, 2023

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@AjayThorve AjayThorve mentioned this pull request Aug 4, 2023
Closed
@github-actions github-actions Bot removed the conda label Aug 4, 2023
exactlyallan
exactlyallan approved these changes Aug 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@exactlyallan exactlyallan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjayThorve Looks good - thanks for all the screenshot updates. One quick thing, just remove the architecture diagram from "10min to cuxfilter" until we can update it - still mentions datatiles.

@raydouglass
Copy link
Copy Markdown
Contributor

raydouglass commented Aug 4, 2023

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@raydouglass raydouglass removed the request for review from a team August 4, 2023 17:02
@AjayThorve
Copy link
Copy Markdown
Member Author

AjayThorve commented Aug 4, 2023

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

Thanks @raydouglass

@AjayThorve
Copy link
Copy Markdown
Member Author

AjayThorve commented Aug 4, 2023

/merge

@AjayThorve
Copy link
Copy Markdown
Member Author

AjayThorve commented Aug 4, 2023

@raydouglass can we merge this in 23.08, it now says the base branch is not under active development.

@raydouglass
Copy link
Copy Markdown
Contributor

raydouglass commented Aug 4, 2023 •
edited
Loading

can we merge this in 23.08, it now says the base branch is not under active development.

Yes. I thought it was merged so I triggered the switch over to 23.10. I'll admin merge this PR.

@raydouglass raydouglass merged commit ef65166 into rapidsai:branch-23.08 Aug 4, 2023
@AjayThorve AjayThorve deleted the doc-updates branch August 4, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@exactlyallan exactlyallan exactlyallan approved these changes

Assignees

No one assigned

Labels

doc Documentation non-breaking Non-breaking change Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AjayThorve @raydouglass @exactlyallan