Refactor to use holoviews powered bar charts#494
Merged
rapids-bot[bot] merged 72 commits intoAug 4, 2023
Merged
Conversation
…yThorve/cuxfilter into improvement/remove-datatiles-support
Closed
exactlyallan
approved these changes
Aug 3, 2023
Member
exactlyallan
left a comment
exactlyallan
left a comment
There was a problem hiding this comment.
Lot of changes! Whats the quick rational for removing the bokeh line chart?
Member
Author
Updated the description, Adding to it: The current implementation had two line charts, one under bokeh, and another under datashader. Removed one to avoid confusion, and bokeh line's implementation that cuxfilter had wasn't really accomplishing anything that bar charts weren't. |
Member
Author
|
/merge |
Merged
raydouglass
approved these changes
Aug 4, 2023
This was referenced Aug 4, 2023
raydouglass
pushed a commit
that referenced
this pull request
Aug 4, 2023
Follow up to #494, updates API docs and screenshots. cc @exactlyallan Authors: - Ajay Thorve (https://github.com/AjayThorve) Approvers: - Allan (https://github.com/exactlyallan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the bokeh charts implementation, and uses holoviews to generate the charts, while also using box-selects instead of range_sliders. This was done for 2 reasons, stability of holoviews api, which also is much more efficient, and to use streams + custom callbacks to link all charts with bar_charts.
Some of the other notable changes:
strcolumns directly for bar chartscuxfilter.charts.line