[Java] Cleaner approach to Enums#995
Closed
narangvivek10 wants to merge 3 commits intorapidsai:branch-25.08from
Closed
[Java] Cleaner approach to Enums#995narangvivek10 wants to merge 3 commits intorapidsai:branch-25.08from
narangvivek10 wants to merge 3 commits intorapidsai:branch-25.08from
Conversation
chatman
reviewed
Jun 9, 2025
| public static MemorySegment prepareTensor(Arena arena, MemorySegment data, long[] shape, int code, int bits, int ndim, | ||
| int deviceType, int lanes) { | ||
|
|
||
| int deviceType, int lanes, MemorySegment strides) { |
Contributor
There was a problem hiding this comment.
Why do we need the strides passed in? All the calls to this seems to be MemorySegment.NULL at the moment.
Also, is this a remnant from some other work? Or is it related to the enums cleanup?
chatman
reviewed
Jun 9, 2025
| for (boolean use: useNativeMemoryDatasets) { | ||
| tmpResultsTopKWithRandomValues(use); | ||
| } | ||
| for (int i = 0; i < 100; i++) { |
Contributor
There was a problem hiding this comment.
There are a lot of whitespace fixes that are unrelated to this PR. Should we deal with linting, whitespace fixes etc in an entirely separate PR?
Contributor
|
FYI, we raised a jextract PR to generate Java native enums. |
Contributor
Author
|
I will create a fresh PR covering this piece once the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes for #989