[Java] Enforce Java code format standard#1049
[Java] Enforce Java code format standard#1049rapids-bot[bot] merged 11 commits intorapidsai:branch-25.08from
Conversation
ldematte
left a comment
There was a problem hiding this comment.
Thanks for this, I really appreciate having not to guess a code format to use.
One nitpick: can we add some mention to it to the README? Perhaps adding a note on how this can be used to format your code to automatically fix all the violations (mvn spotless::apply or similar?)
Yes great idea, in fact, I was thinking that we should add a |
|
Good idea about contributing section. I would prefer a section that
explains setting up IDE, how to debug (across the different language
layers), how to use tools like jextract, nsight, compute-sanitize etc. This
could go into the top level project with a section in Java. FYI, I still
haven't been able to setup the VSCode properly for the C/C++ codebase
(devcontainers didn't work, neither did a regular cmake based project).
…On Fri, 27 Jun, 2025, 9:56 pm Vivek Narang, ***@***.***> wrote:
*narangvivek10* left a comment (rapidsai/cuvs#1049)
<#1049 (comment)>
One nitpick: can we add some mention to it to the README? Perhaps adding a
note on how this can be used to format your code to automatically fix all
the violations (mvn spotless::apply or similar?)
Yes great idea, in fact, I was thinking that we should add a Contributing
section in the readme file with helpful notes (including this one), and any
guidelines for developers in general.
—
Reply to this email directly, view it on GitHub
<#1049 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDCR5ADJF66GTU7GX4F7AD3FVWE3AVCNFSM6AAAAACAB3IWB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMJTGYZTMMZVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
/ok to test 308e9ff |
mythrocks
left a comment
There was a problem hiding this comment.
LGTM. Will check in, pending CI run.
CI seemed to be failing on something transient. I'm re-kicking the failed workflows.
|
/merge |
62e5d0d
into
rapidsai:branch-25.08
|
I have merged this PR. Thank you for this one, @narangvivek10. |
This (and other documentation suggestions above) will be tracked under #1070 and will go in as a separate PR. Thanks! |
Configuration changes to enforce Java code format standard using google-java-format via spotless's maven plugin to comply with the Google Java Style Guide. Spotless is a popular choice and is also used in Apache Lucene.
With this change, the Java code format is checked and fixes for identified style violations are automatically applied (including missing license headers) when invoking
mvn verifyand precisely during itsvalidatephase.@chatman FYI
Fixes #1042