Adding int64 search for MG CAGRA#975
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.08from Jun 5, 2025
Merged
Conversation
cjnolet
added
bug
Member
|
@viclafargue what is the effect on binary size of this PR? cc @cjnolet |
Contributor
Author
The binary size remained at 199M since this is just wrapper code, the |
cjnolet
approved these changes
Jun 5, 2025
Member
|
/merge |
bkarsin
pushed a commit
to bkarsin/cuvs
that referenced
this pull request
Jun 19, 2025
Answers rapidsai#894 and rapidsai#895 by exposing new MG CAGRA search functions with `int64_t` neighbors output type. The PR also updates the tests and benchs to use this new search function. Additionally, the tree merge feature used to perform the KNN merge operation in-place which was an issue, this PR fixes this. Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers #894 and #895 by exposing new MG CAGRA search functions with
int64_tneighbors output type.The PR also updates the tests and benchs to use this new search function.
Additionally, the tree merge feature used to perform the KNN merge operation in-place which was an issue, this PR fixes this.