Revert "Fix kmeans::predict argument order (#915)"#951
Merged
raydouglass merged 1 commit intorapidsai:branch-25.06from May 28, 2025
Merged
Revert "Fix kmeans::predict argument order (#915)"#951raydouglass merged 1 commit intorapidsai:branch-25.06from
raydouglass merged 1 commit intorapidsai:branch-25.06from
Conversation
This reverts commit 5642af3.
divyegala
added
bug
cjnolet
approved these changes
May 28, 2025
Member
|
/merge |
divyegala
commented
May 28, 2025
| raft::device_matrix_view<const double, int> centroids, | ||
| bool normalize_weight, | ||
| raft::device_vector_view<int, int> labels, | ||
| bool normalize_weight, |
Member
Author
There was a problem hiding this comment.
@enp1s0 for reference, we are reverting this PR because the corresponding function bodies for deprecated functions were missing in the source here. rapidsai/cuml#6810
Member
Author
There was a problem hiding this comment.
As you wrote a function annotated with inline that was calling another function in the header, we had a problem in donstream repos. This is because inline is just a suggestion to the compiler, you would need __attribute__((always_inline)) to get this to always work without running into symbol lookup errors.
mythrocks
pushed a commit
to mythrocks/cuvs
that referenced
this pull request
Jun 3, 2025
Revert "Fix kmeans::predict argument order (rapidsai#915)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rapidsai/cuml#6810