Fix kmeans::predict argument order#915
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.06from May 27, 2025
Merged
Fix kmeans::predict argument order#915rapids-bot[bot] merged 3 commits intorapidsai:branch-25.06from
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.06from
Conversation
enp1s0
added
bug
cjnolet
approved these changes
May 27, 2025
Member
|
/merge |
divyegala
added a commit
to divyegala/cuvs
that referenced
this pull request
May 28, 2025
This reverts commit 5642af3.
raydouglass
pushed a commit
that referenced
this pull request
May 28, 2025
Revert "Fix kmeans::predict argument order (#915)"
mythrocks
pushed a commit
to mythrocks/cuvs
that referenced
this pull request
Jun 3, 2025
This PR updates the order of arguments in `kmeans::predict` to match the order in the documentation. The order in the documentation is considered appropriate because it lists the output arguments last, unlike the order of the actual function arguments. Authors: - tsuki (https://github.com/enp1s0) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#915
mythrocks
pushed a commit
to mythrocks/cuvs
that referenced
this pull request
Jun 3, 2025
Revert "Fix kmeans::predict argument order (rapidsai#915)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the order of arguments in
kmeans::predictto match the order in the documentation. The order in the documentation is considered appropriate because it lists the output arguments last, unlike the order of the actual function arguments.