Skip to content

IVF-PQ tests: fix segfault when accessing empty lists #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
May 27, 2025
Merged

IVF-PQ tests: fix segfault when accessing empty lists #933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d55f7b
IVF-PQ tests: fix segfault when accessing empty lists
achirkin May 26, 2025
77d21c0
Fix style
achirkin May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cpp/tests/neighbors/ann_ivf_pq.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,9 @@ class ivf_pq_test : public ::testing::TestWithParam<ivf_pq_inputs> {
// NB: this is not reference, the list is retained; the index will have to create a new list on
// `erase_list` op.
auto old_list = index->lists()[label];
auto n_rows = old_list->size.load();
// If the data is unbalanced the list might be empty, which is actually nullptr
if (!old_list) { return; }
auto n_rows = old_list->size.load();
if (n_rows == 0) { return; }
if (index->metric() == cuvs::distance::DistanceType::CosineExpanded) { return; }

Expand Down Expand Up @@ -350,7 +352,9 @@ class ivf_pq_test : public ::testing::TestWithParam<ivf_pq_inputs> {
void check_packing(index<IdxT>* index, uint32_t label)
{
auto old_list = index->lists()[label];
auto n_rows = old_list->size.load();
// If the data is unbalanced the list might be empty, which is actually nullptr
if (!old_list) { return; }
auto n_rows = old_list->size.load();

if (n_rows == 0) { return; }

Expand Down
Loading