IVF-PQ tests: fix segfault when accessing empty lists#933
Merged
rapids-bot[bot] merged 2 commits intobranch-25.06from May 27, 2025
Merged
IVF-PQ tests: fix segfault when accessing empty lists#933rapids-bot[bot] merged 2 commits intobranch-25.06from
rapids-bot[bot] merged 2 commits intobranch-25.06from
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.06 #933 +/- ##
=============================================
Coverage 84.49% 84.49%
=============================================
Files 20 20
Lines 129 129
=============================================
Hits 109 109
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cjnolet
approved these changes
May 27, 2025
Contributor
Author
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
Member
|
Thanks Artem and Corey! 🙏 |
mythrocks
pushed a commit
to mythrocks/cuvs
that referenced
this pull request
Jun 3, 2025
Check if the `index.lists()[label]` is not an empty shared pointer before accessing its content in tests. This is a follow-up on rapidsai#838, in which I fixed this problem in one place, but not in two others in the same file. Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#933
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if the
index.lists()[label]is not an empty shared pointer before accessing its content in tests.This is a follow-up on #838, in which I fixed this problem in one place, but not in two others in the same file.