Skip to content

fix cuvs_bench.run --groups options #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Jan 24, 2025
Merged

fix cuvs_bench.run --groups options #592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea475eb
fix cuvs_bench.run --groups options
jiangyinzuo Jan 20, 2025
e09b3fa
Merge branch 'branch-25.02' into fix-cuvs-bench-groups
cjnolet Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions python/cuvs_bench/cuvs_bench/run/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ def gather_algorithm_configs(
def load_algorithms_conf(
algos_conf_fs: list,
allowed_algos: Optional[list],
allowed_groups: Optional[list],
allowed_algo_groups: Optional[tuple],
) -> dict:
"""
Expand Down Expand Up @@ -187,8 +188,11 @@ def load_algorithms_conf(
continue
if allowed_algos and algo["name"] not in allowed_algos:
continue
groups = algo.get("groups", {})
if allowed_groups:
groups = {k: v for k, v in groups.items() if k in allowed_groups}
algos_conf[algo["name"]] = {
"groups": algo.get("groups", {}),
"groups": groups,
"constraints": algo.get("constraints", {}),
}
if allowed_algo_groups and algo["name"] in allowed_algo_groups[0]:
Expand Down Expand Up @@ -643,6 +647,7 @@ def run_benchmark(
algos_conf_fs = gather_algorithm_configs(scripts_path, configuration)

allowed_algos = algorithms.split(",") if algorithms else None
allowed_groups = groups.split(",") if groups else None
allowed_algo_groups = (
[algo_group.split(".") for algo_group in algo_groups.split(",")]
if algo_groups
Expand All @@ -651,7 +656,8 @@ def run_benchmark(
algos_conf = load_algorithms_conf(
algos_conf_fs,
allowed_algos,
list(zip(*allowed_algo_groups)) if allowed_algo_groups else None,
allowed_groups,
tuple(zip(*allowed_algo_groups)) if allowed_algo_groups else None,
)

executables_to_run = prepare_executables(
Expand Down