Skip to content

fix cuvs_bench.run --groups options#592

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.02from
jiangyinzuo:fix-cuvs-bench-groups
Jan 24, 2025
Merged

fix cuvs_bench.run --groups options#592
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.02from
jiangyinzuo:fix-cuvs-bench-groups

Conversation

@jiangyinzuo
Copy link
Copy Markdown
Contributor

@jiangyinzuo jiangyinzuo commented Jan 20, 2025

issue: #585

@jiangyinzuo jiangyinzuo requested a review from a team as a code owner January 20, 2025 14:14
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jan 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dantegd dantegd added bug Something isn't working non-breaking Introduces a non-breaking change labels Jan 22, 2025
Copy link
Copy Markdown
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jiangyinzuo ! The patch looks good to me

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jan 22, 2025

/ok to test

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jan 23, 2025

/ok to test

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jan 24, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 44dafe6 into rapidsai:branch-25.02 Jan 24, 2025
@jiangyinzuo jiangyinzuo deleted the fix-cuvs-bench-groups branch February 22, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change Python

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants