CMake check for FAISS use in benchmarks#1591
Merged
rapids-bot[bot] merged 4 commits intorapidsai:mainfrom Nov 26, 2025
Merged
Conversation
…H_USE_FAISS is now set to OFF if all relevant flags are set OFF. The status is reported in the cmake log: -- Finding or building hnswlib -- Checking for FAISS use in benchmarks... -- CUVS_ANN_BENCH_USE_FAISS is OFF Closes rapidsai#1590.
irina-resh-nvda
added
bug
tfeher
requested changes
Nov 25, 2025
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks Irina for the PR, it is great to have a fix for this issue! Here are my comments:
tfeher
approved these changes
Nov 25, 2025
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks Irina for the updates. The PR looks good to me.
Contributor
|
/ok to test 864012f |
tfeher
changed the title
Contributor
|
/ok to test a3951ab |
Contributor
|
/ok to test cb964bd |
Contributor
|
/merge |
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Dec 6, 2025
CUVS_ANN_BENCH_USE_FAISS is now set to OFF if all relevant flags are set OFF. The status is reported in the cmake log: -- Finding or building hnswlib -- Checking for FAISS use in benchmarks... -- CUVS_ANN_BENCH_USE_FAISS is OFF closes rapidsai#1590. Authors: - https://github.com/irina-resh-nvda Approvers: - Tamas Bela Feher (https://github.com/tfeher) URL: rapidsai#1591
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUVS_ANN_BENCH_USE_FAISS is now set to OFF if all relevant flags are set OFF.
The status is reported in the cmake log:
-- Finding or building hnswlib
-- Checking for FAISS use in benchmarks...
-- CUVS_ANN_BENCH_USE_FAISS is OFF
closes #1590.