Skip to content

[BUG] CUVS_ANN_BENCH_USE_FAISS stays on even if all relevant build flags are set off #1590

@irina-resh-nvda

Description

@irina-resh-nvda

Describe the bug
CUVS_ANN_BENCH_USE_FAISS stays on even if all relevant build flags are set off

Steps/Code to reproduce bug
running cmake, for example, with a command
cmake .. -DCUVS_NVTX=ON -DBUILD_MG_ALGOS=OFF -DBUILD_TESTS=OFF -DBUILD_C_TESTS=OFF -DBUILD_CUVS_BENCH=ON -DCUVS_ANN_BENCH_USE_FAISS_GPU_FLAT=OFF -DCUVS_ANN_BENCH_USE_FAISS_GPU_IVF_FLAT=OFF -DCUVS_ANN_BENCH_USE_FAISS_GPU_CAGRA=OFF -DCUVS_ANN_BENCH_USE_FAISS_GPU_IVF_PQ=OFF -DCUVS_ANN_BENCH_USE_FAISS_CPU_FLAT=OFF -DCUVS_ANN_BENCH_USE_FAISS_CPU_IVF_FLAT=OFF -DCUVS_ANN_BENCH_USE_FAISS_CPU_IVF_PQ=OFF -DCUVS_ANN_BENCH_USE_FAISS_CPU_HNSW_FLAT=OFF -DCUVS_ANN_BENCH_USE_FAISS_GPU_CAGRA_HNSW=OFF -DCUVS_ANN_BENCH_USE_CUVS_CAGRA_HNSWLIB=OFF -DCUVS_ANN_BENCH_USE_HNSWLIB=OFF -DCUVS_ANN_BENCH_USE_GGNN=OFF -DCUVS_ANN_BENCH_USE_DISKANN=OFF -DCUVS_ANN_BENCH_USE_CUVS_VAMANA=OFF -DCUVS_ANN_BENCH_USE_CUVS_CAGRA_DISKANN=OFF -DCUVS_ANN_BENCH_USE_CUVS_MG=OFF -DDISABLE_DEPRECATION_WARNINGS=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DCMAKE_CUDA_ARCHITECTURES=80 -DCMAKE_BUILD_TYPE=Release

still adds FAISS include to the benchmark modules

Expected behavior
CUVS_ANN_BENCH_USE_FAISS should be set OFF if every relevant flag is off

Additional context
I already made a fix; reporting this bug to link to a branch

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions