[Java] Fix CagraBuildAndSearchIT concurrent deallocation errors#1510
Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom Nov 10, 2025
Merged
Conversation
ldematte
changed the title
CagraBuildAndSearchIT concurrent deallocation errorsCagraBuildAndSearchIT concurrent deallocation errors
mythrocks
reviewed
Nov 10, 2025
|
|
||
| @Override | ||
| public String toString() { | ||
| return String.format("%dx%d %s @ 0x%016X", size, columns, dataType, memorySegment.address()); |
mythrocks
reviewed
Nov 10, 2025
Comment on lines
+44
to
+47
| Tests run using a randomized runner. Specific failures can be reproduced running a test suite with a specific seed, | ||
| by passing `-Dtests.seed=42FC5CC6B4C6BA8E` (where `42FC5CC6B4C6BA8E` has to be | ||
| replaced with your specific seed). It also possible to re-run a single test, but | ||
| in this case it's necessary to pass the extended seed (suite:method), e.g. |
mythrocks
added
bug
Contributor
|
I feel a little silly not to have suspected this being the problem, and barking up the wrong tree. Good catch, @ldematte! This is a decent fix. In the short term, we can keep this to be the fix. In the longer term, I think this could benefit from a reference-counted close() mechanism. That's the method used in other projects I've worked on. I'm open to other ideas, of course. |
Contributor
|
/ok to test 53bc861 |
mythrocks
changed the title
CagraBuildAndSearchIT concurrent deallocation errorsCagraBuildAndSearchIT concurrent deallocation errors
mythrocks
approved these changes
Nov 10, 2025
Contributor
|
/merge |
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1467 (see issue for details)
I added some diagnostic (debug level) that I kept in the test, as it might be useful for future investigations.