[Java] Bindings, tests and benchmarks for RMM pooled memory#1453
Merged
rapids-bot[bot] merged 9 commits intorapidsai:release/25.12from Dec 1, 2025
Merged
Conversation
ldematte
commented
Nov 10, 2025
| } | ||
|
|
||
| @Override | ||
| public String toString() { |
ldematte
commented
Nov 10, 2025
| @Before | ||
| public void setup() { | ||
| assumeTrue("not supported on " + System.getProperty("os.name"), isLinuxAmd64()); | ||
| CuVSProvider.provider().enableRMMPooledMemory(10, 60); |
ldematte
commented
Nov 10, 2025
| assumeTrue(isLinuxAmd64()); | ||
| initializeRandom(); | ||
| log.trace("Random context initialized for test."); | ||
| CuVSProvider.provider().enableRMMPooledMemory(10, 60); |
ldematte
commented
Nov 10, 2025
| public void setup() { | ||
| assumeTrue("not supported on " + System.getProperty("os.name"), isLinuxAmd64()); | ||
| initializeRandom(); | ||
| CuVSProvider.provider().enableRMMPooledMemory(10, 60); |
ldematte
changed the title
Contributor
|
I've merged #1510, which seems to have introduced conflicts in the |
Contributor
Author
|
Thanks @mythrocks, I'll rebase |
# Conflicts: # java/cuvs-java/src/main/java/com/nvidia/cuvs/spi/CuVSProvider.java # java/cuvs-java/src/main/java/com/nvidia/cuvs/spi/UnsupportedProvider.java # java/cuvs-java/src/main/java22/com/nvidia/cuvs/spi/JDKProvider.java # java/cuvs-java/src/test/java/com/nvidia/cuvs/CagraBuildAndSearchIT.java # java/cuvs-java/src/test/java/com/nvidia/cuvs/CuVSMatrixIT.java
…ild/cuvsBruteForceSearch
ldematte
force-pushed
the
java/rmm-memory-pool-functions
branch
from
d6a6f38 to
8cec4dc
Compare
Contributor
Author
|
@mythrocks I have rebased this onto 25.12 too |
mythrocks
added
feature request
mythrocks
approved these changes
Nov 20, 2025
mythrocks
changed the title
Contributor
|
I've taken @rapidsai/cuvs-python-codeowners, @rapidsai/ci-codeowners, etc. off of this review. The changes are all in Java, and straightforward. |
Contributor
|
/ok to test d74f38e |
mythrocks
reviewed
Nov 20, 2025
| @@ -0,0 +1,53 @@ | |||
| package com.nvidia.cuvs; | |||
Contributor
There was a problem hiding this comment.
Need to include the copyright header here.
Contributor
There was a problem hiding this comment.
Let me see if that change helps.
Contributor
|
/ok to test bd8670a |
Contributor
|
Hmm. Odd C++ compile error: Included from |
Contributor
|
/ok to test bd8670a |
1 similar comment
Contributor
|
/ok to test bd8670a |
Contributor
|
/ok to test fc7b55c |
Contributor
|
/ok to test ed92aa9 |
Contributor
|
/ok to test 6900dfe |
mythrocks
reviewed
Dec 1, 2025
|
|
||
| @Test | ||
| public void testPooledByteDeviceDatasetRowGetAccess() throws Throwable { | ||
| withPooledMemory(this::testByteDeviceDatasetRowGetAccess); |
Contributor
There was a problem hiding this comment.
This is an elegant way to express this test.
mythrocks
approved these changes
Dec 1, 2025
Contributor
|
/merge |
rapids-bot
Bot
merged commit cf5309a
into
rapidsai:release/25.12
172 of 174 checks passed
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
copy-pr-bot Bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
Exposes `cuvsRMMPoolMemoryResourceEnable`/`cuvsRMMMemoryResourceReset` via the Java API, with tests and benchmarks Authors: - Lorenzo Dematté (https://github.com/ldematte) - MithunR (https://github.com/mythrocks) Approvers: - MithunR (https://github.com/mythrocks) URL: #1453
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
cuvsRMMPoolMemoryResourceEnable/cuvsRMMMemoryResourceResetvia the Java API, with tests and benchmarks