Skip to content

Add libaio to cuvs-bench-cpu, improve bench dependencies #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 7 commits into from
Nov 7, 2025
Merged

Add libaio to cuvs-bench-cpu, improve bench dependencies #1480

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62e5731
add libaio to run set
tarang-jain Oct 30, 2025
be592bb
run_export correct
tarang-jain Oct 30, 2025
4969cee
Merge branch 'main' into cuvs-bench-cpu
cjnolet Nov 3, 2025
4ce7e59
Merge branch 'main' into cuvs-bench-cpu
tarang-jain Nov 7, 2025
6d491c9
Use run-export for libaio
bdice Nov 7, 2025
571815f
Refactor packaging
bdice Nov 7, 2025
58d0744
Remove benchmark from conda dependencies
bdice Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda/recipes/cuvs-bench-cpu/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,11 @@ requirements:
- scikit-learn>=1.5
- if: linux64
then:
- libaio # Required for diskann_ssd at runtime
- mkl =2023
ignore_run_exports:
by_name:
- glog
- libaio
- libboost
- libcublas
- mkl # relaxes pin from host `mkl-devel`
Expand Down
5 changes: 3 additions & 2 deletions conda/recipes/cuvs-bench/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,14 @@ requirements:
- rmm =${{ minor_version }}
- scikit-learn>=1.5
- if: linux64
then: mkl =2023
then:
- libaio # Required for diskann_ssd at runtime
Copy link
Copy Markdown
Contributor

@bdice bdice Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is libaio also needed to build the package? Do we need an entry in host for that?

The entry in ignore_run_exports wasn't doing anything because no run exports were being added. Run exports would only be present if libaio was in host to begin with.

Copy link
Copy Markdown
Contributor Author

@tarang-jain tarang-jain Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its needed to build DiskANN and we are directly linking the wrapper to it here:

cuvs/cpp/bench/ann/CMakeLists.txt

Line 336 in d8fdd7d

NAME DISKANN_MEMORY PATH src/diskann/diskann_benchmark.cpp LINKS diskann::diskann aio

Copy link
Copy Markdown
Contributor Author

@tarang-jain tarang-jain Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like libaio is in host for cuvs-bench-cpu, right?

- mkl =2023
ignore_run_exports:
by_name:
- cuda-version
- cuda-cudart
- glog
- libaio
- libboost
- libcublas
- mkl
Expand Down
Loading