Add libaio to cuvs-bench-cpu, improve bench dependencies#1480
Merged
rapids-bot[bot] merged 7 commits intorapidsai:mainfrom Nov 7, 2025
Merged
Add libaio to cuvs-bench-cpu, improve bench dependencies#1480rapids-bot[bot] merged 7 commits intorapidsai:mainfrom
rapids-bot[bot] merged 7 commits intorapidsai:mainfrom
Conversation
tarang-jain
added
bug
cjnolet
approved these changes
Nov 3, 2025
bdice
requested changes
Nov 3, 2025
| - if: linux64 | ||
| then: mkl =2023 | ||
| then: | ||
| - libaio # Required for diskann_ssd at runtime |
Contributor
There was a problem hiding this comment.
Is libaio also needed to build the package? Do we need an entry in host for that?
The entry in ignore_run_exports wasn't doing anything because no run exports were being added. Run exports would only be present if libaio was in host to begin with.
Contributor
Author
There was a problem hiding this comment.
Its needed to build DiskANN and we are directly linking the wrapper to it here:
cuvs/cpp/bench/ann/CMakeLists.txt
Line 336 in d8fdd7d
Contributor
Author
There was a problem hiding this comment.
Looks like libaio is in host for cuvs-bench-cpu, right?
bdice
approved these changes
Nov 7, 2025
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Discussed with @tarang-jain over a call. We found some other improvements to conda recipes:
- We can remove all C++ dependencies in
cuvs-benchrecipe because it is pure Python. Those dependencies are already coming fromlibcuvs-bench-annand don't need to be respecified in Python. - We don't need to use
benchmarkconda packages anywhere anymore, we always use CPM to fetch and statically link Google Benchmark here (we've already made this change elsewhere in RAPIDS) - Small fix to
get_nlohmann_json.cmake-- the log message was forglogby mistake
bdice
changed the title
Contributor
Author
|
/merge |
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libaio is used directly at run time by the diskann_ssd benchmarking wrapper in cuvs-bench-cpu.