Skip to content

[Java] Fix POM#1106

Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.08from
ldematte:java/fix-pom
Jul 15, 2025
Merged

[Java] Fix POM#1106
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.08from
ldematte:java/fix-pom

Conversation

@ldematte
Copy link
Copy Markdown
Contributor

@ldematte ldematte commented Jul 11, 2025

As reported in #1090, we are producing a "broken" "jar with dependecies" today: the Jar contains extra files that make it impossible to consume from a modularized application, as it breaks the module definition.

This PR fixes this by:

  • removing spotless as a dependency: adding it as a dependency is not needed, as spotless is used at build time
  • removing the jar-with-dependency build task: we don't need it, as we don't have dependencies today. If we have in the future, we can re-introduce it, with a better handling of the merge process
  • change the build script to install in the local maven repository the "regular" jar produced by the build process

EDIT: after review, we decided to revert the removal of the task creating jar-with-dependency, as we might need it in the future (will need fixing anyway, but we can defer that until we need it).

Closes #1090

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jul 11, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ldematte ldematte changed the title [Fix POM [Java] Fix POM Jul 11, 2025
@ldematte ldematte marked this pull request as ready for review July 11, 2025 13:34
@ldematte ldematte requested a review from a team as a code owner July 11, 2025 13:34
@ldematte ldematte requested a review from AyodeAwe July 11, 2025 13:34
@cjnolet cjnolet moved this from Todo to In Progress in Unstructured Data Processing Jul 11, 2025
@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 11, 2025
@ldematte ldematte requested a review from a team as a code owner July 12, 2025 10:04
@ldematte
Copy link
Copy Markdown
Contributor Author

@mythrocks I have updated the PR to keep the jar-with-dependencies

@mythrocks
Copy link
Copy Markdown
Contributor

/ok to test a132570

@mythrocks
Copy link
Copy Markdown
Contributor

The CI builds should be fixed once #1114 is resolved.

@benfred
Copy link
Copy Markdown
Contributor

benfred commented Jul 15, 2025

/ok to test f20d41a

@mythrocks
Copy link
Copy Markdown
Contributor

Will prioritize #1034 first, to address the build failures.

@mythrocks
Copy link
Copy Markdown
Contributor

/ok to test d64157d

@mythrocks
Copy link
Copy Markdown
Contributor

/merge

@mythrocks
Copy link
Copy Markdown
Contributor

@KyleFromNVIDIA, could I please bother you for a packaging-owners review for this change?

@rapids-bot rapids-bot Bot merged commit c59bc27 into rapidsai:branch-25.08 Jul 15, 2025
53 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unstructured Data Processing Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG][Java] The JAR with dependencies (for maven repository installation) is broken

5 participants