Commit c59bc27
authored
[Java] Fix POM (#1106)
As reported in #1090, we are producing a "broken" "jar with dependecies" today: the Jar contains extra files that make it impossible to consume from a modularized application, as it breaks the module definition.
This PR fixes this by:
- removing `spotless` as a dependency: adding it as a dependency is not needed, as spotless is used at build time
- ~~removing the `jar-with-dependency` build task: we don't need it, as we don't have dependencies today. If we have in the future, we can re-introduce it, with a better handling of the merge process~~
- change the build script to install in the local maven repository the "regular" jar produced by the build process
EDIT: after review, we decided to revert the removal of the task creating `jar-with-dependency`, as we might need it in the future (will need fixing anyway, but we can defer that until we need it).
Closes #1090
Authors:
- Lorenzo Dematté (https://github.com/ldematte)
- Ben Frederickson (https://github.com/benfred)
- MithunR (https://github.com/mythrocks)
Approvers:
- MithunR (https://github.com/mythrocks)
- Bradley Dice (https://github.com/bdice)
URL: #11061 parent 32d6d83 commit c59bc27
2 files changed
Lines changed: 1 addition & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | 104 | | |
112 | 105 | | |
113 | 106 | | |
| |||
0 commit comments