Skip to content

Commit c59bc27

Browse files
authored
[Java] Fix POM (#1106)
As reported in #1090, we are producing a "broken" "jar with dependecies" today: the Jar contains extra files that make it impossible to consume from a modularized application, as it breaks the module definition. This PR fixes this by: - removing `spotless` as a dependency: adding it as a dependency is not needed, as spotless is used at build time - ~~removing the `jar-with-dependency` build task: we don't need it, as we don't have dependencies today. If we have in the future, we can re-introduce it, with a better handling of the merge process~~ - change the build script to install in the local maven repository the "regular" jar produced by the build process EDIT: after review, we decided to revert the removal of the task creating `jar-with-dependency`, as we might need it in the future (will need fixing anyway, but we can defer that until we need it). Closes #1090 Authors: - Lorenzo Dematté (https://github.com/ldematte) - Ben Frederickson (https://github.com/benfred) - MithunR (https://github.com/mythrocks) Approvers: - MithunR (https://github.com/mythrocks) - Bradley Dice (https://github.com/bdice) URL: #1106
1 parent 32d6d83 commit c59bc27

2 files changed

Lines changed: 1 addition & 8 deletions

File tree

java/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,5 @@ fi
4040
export LD_LIBRARY_PATH=${CURDIR}/../cpp/build:${LD_LIBRARY_PATH}
4141
cd cuvs-java
4242
mvn verify "${MAVEN_VERIFY_ARGS[@]}" \
43-
&& mvn install:install-file -Dfile=./target/cuvs-java-$VERSION-jar-with-dependencies.jar -DgroupId=$GROUP_ID -DartifactId=cuvs-java -Dversion=$VERSION -Dpackaging=jar \
43+
&& mvn install:install-file -Dfile=./target/cuvs-java-$VERSION.jar -DgroupId=$GROUP_ID -DartifactId=cuvs-java -Dversion=$VERSION -Dpackaging=jar \
4444
&& cp pom.xml ./target/

java/cuvs-java/pom.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,6 @@
101101
<version>4.13.1</version>
102102
<scope>test</scope>
103103
</dependency>
104-
105-
<dependency>
106-
<groupId>com.diffplug.spotless</groupId>
107-
<artifactId>spotless-maven-plugin</artifactId>
108-
<version>2.44.5</version>
109-
</dependency>
110-
111104
</dependencies>
112105

113106
<build>

0 commit comments

Comments
 (0)