Skip to content

Remove raft math.cuh and matrix.cuh#7797

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
aamijar:remove-raft-math-matrix.cuh
Feb 13, 2026
Merged

Remove raft math.cuh and matrix.cuh#7797
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
aamijar:remove-raft-math-matrix.cuh

Conversation

@aamijar
Copy link
Copy Markdown
Member

@aamijar aamijar commented Feb 13, 2026

Follow up to #7752. Remove two remaining headers that were supposed to be removed.

@aamijar aamijar requested a review from a team as a code owner February 13, 2026 07:57
@aamijar aamijar requested review from divyegala and jcrist February 13, 2026 07:57
@aamijar aamijar added non-breaking Non-breaking change bug Something isn't working improvement Improvement / enhancement to an existing function and removed bug Something isn't working labels Feb 13, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 13, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed unused internal dependencies to optimize code maintainability and build configuration.

Walkthrough

Two include directives are removed from the SVD CUDA implementation file. The removed headers are for RAFT matrix utilities. No functional logic or control flow modifications are present in this change.

Changes

Cohort / File(s) Summary
Header Cleanup
cpp/src_prims/opg/linalg/svd.cu
Removed two unused include directives: <raft/matrix/math.cuh> and <raft/matrix/matrix.cuh>.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the primary change: removing two specific raft headers from the codebase.
Description check ✅ Passed The description is related to the changeset, explaining this is a follow-up to remove headers that were intended to be removed in a previous PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aamijar
Copy link
Copy Markdown
Member Author

aamijar commented Feb 13, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 73eb6ee into rapidsai:main Feb 13, 2026
215 of 238 checks passed
dantegd added a commit to dantegd/cuml that referenced this pull request Feb 17, 2026
Follow up to rapidsai#7752. Remove two remaining headers that were supposed to be removed.

Authors:
  - Anupam (https://github.com/aamijar)

Approvers:
  - Simon Adorf (https://github.com/csadorf)

URL: rapidsai#7797
rapids-bot Bot pushed a commit to rapidsai/raft that referenced this pull request Feb 23, 2026
Depends on rapidsai/cuvs#1763. Resolves #2937

This PR does the following:
1. Removes files with the following message
```cpp
#ifndef RAFT_HIDE_DEPRECATION_WARNINGS
#pragma message(__FILE__                                                  \
                " is deprecated and will be removed in a future release." \
                " Please use the raft/sparse/solver version instead.")
#endif
```
2. Removes files with the following message
```cpp
/**
 * This file is deprecated and will be removed in a future release.
 */
```
3. Pulls from correct non-deprecated headers like using`raft/util/cudart_utils.cuh` instead of `raft/core/cudart_utils.cuh`
4. Pulls correct functionality from non-deprecated headers like using `raft/linalg/matrix_vector.cuh` instead of `raft/matrix/math.cuh`. This requires using the newer mdspan based apis.
5. Consolidates `gemm.cuh` and `gemm.hpp` into just `gemm.cuh`

**Update:**
There were a couple of fixes included in this PR that I have decoupled. Instead those fixes should be merged in #2940.
This will allow us to unravel the merging sequence better to avoid breaking changes altogether. Still marking this PR as breaking for awareness purposes.
After merging #2940, the cuml side and cuvs side can be updated to use the non-deprecated apis. Then we can merge this raft PR to remove the deprecated and unused headers.

**Update:**
There are a couple of breaking changes that affect cugraph and cuopt, so we will need to merge fixes for those first.

**Merging sequence:**
#2940 -> rapidsai/cuvs#1763 -> rapidsai/cuml#7752 -> rapidsai/cuml#7797 -> rapidsai/cugraph#5429 -> NVIDIA/cuopt#865 -> #2939

**Downstream libraries CI status:**
cuvs: 🟢
cuml: 🟢
cugraph: 🟢
cuopt: 🟢

Authors:
  - Anupam (https://github.com/aamijar)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #2939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants