Skip to content

Update raft headers#5429

Merged
rapids-bot[bot] merged 6 commits intorapidsai:mainfrom
aamijar:ci-test-raft
Feb 23, 2026
Merged

Update raft headers#5429
rapids-bot[bot] merged 6 commits intorapidsai:mainfrom
aamijar:ci-test-raft

Conversation

@aamijar
Copy link
Copy Markdown
Member

@aamijar aamijar commented Feb 13, 2026

Testing with rapidsai/raft#2939 and adding fixes.

@aamijar aamijar requested a review from a team as a code owner February 13, 2026 17:14
@aamijar aamijar requested a review from a team as a code owner February 13, 2026 23:17
Comment thread cpp/cmake/thirdparty/get_raft.cmake Outdated
@aamijar aamijar changed the title Test CI with raft #2939 Update raft headers Feb 14, 2026
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 14, 2026
Copy link
Copy Markdown
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdice
Copy link
Copy Markdown
Contributor

bdice commented Feb 23, 2026

/merge

@rapids-bot rapids-bot Bot merged commit e0d78aa into rapidsai:main Feb 23, 2026
76 checks passed
rapids-bot Bot pushed a commit to rapidsai/raft that referenced this pull request Feb 23, 2026
Depends on rapidsai/cuvs#1763. Resolves #2937

This PR does the following:
1. Removes files with the following message
```cpp
#ifndef RAFT_HIDE_DEPRECATION_WARNINGS
#pragma message(__FILE__                                                  \
                " is deprecated and will be removed in a future release." \
                " Please use the raft/sparse/solver version instead.")
#endif
```
2. Removes files with the following message
```cpp
/**
 * This file is deprecated and will be removed in a future release.
 */
```
3. Pulls from correct non-deprecated headers like using`raft/util/cudart_utils.cuh` instead of `raft/core/cudart_utils.cuh`
4. Pulls correct functionality from non-deprecated headers like using `raft/linalg/matrix_vector.cuh` instead of `raft/matrix/math.cuh`. This requires using the newer mdspan based apis.
5. Consolidates `gemm.cuh` and `gemm.hpp` into just `gemm.cuh`

**Update:**
There were a couple of fixes included in this PR that I have decoupled. Instead those fixes should be merged in #2940.
This will allow us to unravel the merging sequence better to avoid breaking changes altogether. Still marking this PR as breaking for awareness purposes.
After merging #2940, the cuml side and cuvs side can be updated to use the non-deprecated apis. Then we can merge this raft PR to remove the deprecated and unused headers.

**Update:**
There are a couple of breaking changes that affect cugraph and cuopt, so we will need to merge fixes for those first.

**Merging sequence:**
#2940 -> rapidsai/cuvs#1763 -> rapidsai/cuml#7752 -> rapidsai/cuml#7797 -> rapidsai/cugraph#5429 -> NVIDIA/cuopt#865 -> #2939

**Downstream libraries CI status:**
cuvs: 🟢
cuml: 🟢
cugraph: 🟢
cuopt: 🟢

Authors:
  - Anupam (https://github.com/aamijar)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #2939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants