Fix scikit-learn 1.8 test incompatibilities#7589
Merged
rapids-bot[bot] merged 16 commits intorapidsai:mainfrom Dec 15, 2025
Merged
Fix scikit-learn 1.8 test incompatibilities#7589rapids-bot[bot] merged 16 commits intorapidsai:mainfrom
rapids-bot[bot] merged 16 commits intorapidsai:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
csadorf
added
improvement
Contributor
Author
|
/ok to test 28d0702 |
csadorf
force-pushed
the
fix/scikit-learn-1.8-incompatibilities
branch
from
28d0702 to
bf8a042
Compare
csadorf
force-pushed
the
fix/scikit-learn-1.8-incompatibilities
branch
from
bf8a042 to
be53e2c
Compare
Contributor
Author
|
/ok to test be53e2c |
Contributor
Author
|
/ok to test 169365b |
Contributor
Author
|
/ok to test f7bd3cd |
csadorf
force-pushed
the
fix/scikit-learn-1.8-incompatibilities
branch
from
f7bd3cd to
72b46d9
Compare
Contributor
Author
|
/ok to test 72b46d9 |
csadorf
force-pushed
the
fix/scikit-learn-1.8-incompatibilities
branch
from
0c64a12 to
72b46d9
Compare
This reverts commit 0b41aeb.
The package umap-learn package is incompatible.
UMAP-learn is not yet compatible with scikit-learn 1.8.
csadorf
force-pushed
the
fix/scikit-learn-1.8-incompatibilities
branch
from
72b46d9 to
2b910d5
Compare
Contributor
Author
|
/ok to test 2b910d5 |
csadorf
commented
Dec 12, 2025
Comment on lines
+915
to
+917
| # skip with sklearn version 1.8.0.dev0 | ||
| if Version(sklearn.__version__) >= Version("1.8.0.dev0"): | ||
| pytest.skip("xgboost is incompatible with sklearn >= 1.8.0.dev0") |
Contributor
Author
There was a problem hiding this comment.
We can revert this once dmlc/xgboost#11858 is released.
gforsyth
approved these changes
Dec 12, 2025
bdice
approved these changes
Dec 12, 2025
Contributor
Author
|
/merge |
mani-builds
pushed a commit
to mani-builds/cuml
that referenced
this pull request
Jan 11, 2026
This PR reverts rapidsai#7588. and updates the test suite to ensure compatibility with scikit-learn 1.8. Closes rapidsai#7599. Authors: - Simon Adorf (https://github.com/csadorf) Approvers: - Jim Crist-Harif (https://github.com/jcrist) - Gil Forsyth (https://github.com/gforsyth) - Bradley Dice (https://github.com/bdice) URL: rapidsai#7589
rapids-bot Bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
## Summary Adds a `set` command to `xfail_manager.py` for batch modification of xfail test metadata, and simplifies `summarize-results.py` by removing its xfail list update functionality. ## Motivation This toolset was expanded during work on #7589 to streamline xfail list maintenance for scikit-learn 1.8 compatibility. These improvements are useful for ongoing xfail list management and should be maintained in the codebase. ## Changes - **xfail_manager.py**: Added `set` command to modify test metadata (reason, condition, marker, strict, run) for specified tests - **summarize-results.py**: - Removed `--update-xfail-list`, `--in-place`, `--xpassed` options (now handled by xfail_manager.py) - Added `-k/--filter` for substring filtering and `--test-id-prefix` for prefixing test IDs - **test_config.yaml**: Added `test_id_prefix` config option - **umap/run-tests.sh**: Fixed `--rootdir` to point to UMAP repo -- makes it so that the test id prefix matches between report and xfail list - **README.md**: Updated documentation for new tooling workflow ## Example Usage ```bash # Set a new reason for specific tests ./xfail_manager.py set xfail-list.yaml "test_foo" "test_bar" --reason "Known issue #123" # Mark tests as flaky (non-strict) ./xfail_manager.py set xfail-list.yaml "test_flaky" --no-strict # Filter summarize-results output ./summarize-results.py results.xml --format traceback -k "logistic" ``` Authors: - Simon Adorf (https://github.com/csadorf) Approvers: - Tim Head (https://github.com/betatim) - Dante Gama Dessavre (https://github.com/dantegd) URL: #7607
viclafargue
pushed a commit
to viclafargue/cuml
that referenced
this pull request
Jan 26, 2026
## Summary Adds a `set` command to `xfail_manager.py` for batch modification of xfail test metadata, and simplifies `summarize-results.py` by removing its xfail list update functionality. ## Motivation This toolset was expanded during work on rapidsai#7589 to streamline xfail list maintenance for scikit-learn 1.8 compatibility. These improvements are useful for ongoing xfail list management and should be maintained in the codebase. ## Changes - **xfail_manager.py**: Added `set` command to modify test metadata (reason, condition, marker, strict, run) for specified tests - **summarize-results.py**: - Removed `--update-xfail-list`, `--in-place`, `--xpassed` options (now handled by xfail_manager.py) - Added `-k/--filter` for substring filtering and `--test-id-prefix` for prefixing test IDs - **test_config.yaml**: Added `test_id_prefix` config option - **umap/run-tests.sh**: Fixed `--rootdir` to point to UMAP repo -- makes it so that the test id prefix matches between report and xfail list - **README.md**: Updated documentation for new tooling workflow ## Example Usage ```bash # Set a new reason for specific tests ./xfail_manager.py set xfail-list.yaml "test_foo" "test_bar" --reason "Known issue rapidsai#123" # Mark tests as flaky (non-strict) ./xfail_manager.py set xfail-list.yaml "test_flaky" --no-strict # Filter summarize-results output ./summarize-results.py results.xml --format traceback -k "logistic" ``` Authors: - Simon Adorf (https://github.com/csadorf) Approvers: - Tim Head (https://github.com/betatim) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#7607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #7588. and updates the test suite to ensure compatibility with scikit-learn 1.8.
Closes #7599.