Pin scikit-learn<1.8 in test dependencies#7588
Merged
gforsyth merged 2 commits intorapidsai:release/25.12from Dec 10, 2025
Merged
Pin scikit-learn<1.8 in test dependencies#7588gforsyth merged 2 commits intorapidsai:release/25.12from
gforsyth merged 2 commits intorapidsai:release/25.12from
Conversation
github-actions
Bot
added
conda
bdice
reviewed
Dec 10, 2025
(assuming tests pass)
bdice
reviewed
Dec 10, 2025
bdice
approved these changes
Dec 10, 2025
csadorf
added a commit
to csadorf/cuml
that referenced
this pull request
Dec 11, 2025
This reverts commit 0b41aeb.
csadorf
added a commit
to csadorf/cuml
that referenced
this pull request
Dec 12, 2025
This reverts commit 0b41aeb.
csadorf
added a commit
to csadorf/cuml
that referenced
this pull request
Dec 12, 2025
This reverts commit 0b41aeb.
rapids-bot Bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
This PR reverts #7588. and updates the test suite to ensure compatibility with scikit-learn 1.8. Closes #7599. Authors: - Simon Adorf (https://github.com/csadorf) Approvers: - Jim Crist-Harif (https://github.com/jcrist) - Gil Forsyth (https://github.com/gforsyth) - Bradley Dice (https://github.com/bdice) URL: #7589
mani-builds
pushed a commit
to mani-builds/cuml
that referenced
this pull request
Jan 11, 2026
While cuML itself is compatible with scikit-learn 1.8, some of our dependencies (umap-learn, hdbscan, xgboost) are not. A very small number of tests is not yet compatible either.
mani-builds
pushed a commit
to mani-builds/cuml
that referenced
this pull request
Jan 11, 2026
This PR reverts rapidsai#7588. and updates the test suite to ensure compatibility with scikit-learn 1.8. Closes rapidsai#7599. Authors: - Simon Adorf (https://github.com/csadorf) Approvers: - Jim Crist-Harif (https://github.com/jcrist) - Gil Forsyth (https://github.com/gforsyth) - Bradley Dice (https://github.com/bdice) URL: rapidsai#7589
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While cuML itself is compatible with scikit-learn 1.8, some of our dependencies (umap-learn, hdbscan, xgboost) are not. A very small number of tests is not yet compatible either.