Skip to content

Fix DBSCAN overflow #7421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Nov 3, 2025
Merged

Fix DBSCAN overflow #7421

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96d3daa
fallback to int64
divyegala Oct 31, 2025
ac3f00a
Merge branch 'main' into dbscan-overflow
divyegala Oct 31, 2025
6722278
Update python/cuml/cuml/cluster/dbscan.pyx
divyegala Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/cuml/cuml/cluster/dbscan.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import numpy as np

from cuml.common.array_descriptor import CumlArrayDescriptor
from cuml.common.doc_utils import generate_docstring
from cuml.internals import logger
from cuml.internals.array import CumlArray
from cuml.internals.base import Base
from cuml.internals.input_utils import input_to_cuml_array
Expand Down Expand Up @@ -344,6 +345,10 @@ class DBSCAN(Base,
check_dtype=[np.float32, np.float64]
)

if n_rows * n_cols > (2**31 - 1):
out_dtype = "int64"
logger.warn("Using int64 for out_dtype because n_rows * n_cols >= INT_MAX")
Comment thread
divyegala marked this conversation as resolved.
Outdated

if n_rows == 0 or n_cols == 0:
raise ValueError(
f"DBSCAN requires at least one row and one column to fit, "
Expand Down
Loading