Fix DBSCAN overflow#7421
Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom Nov 3, 2025
Merged
Conversation
dantegd
reviewed
Oct 31, 2025
Member
dantegd
left a comment
dantegd
left a comment
There was a problem hiding this comment.
Have one comment, besides that the logic looks good
Co-authored-by: Dante Gama Dessavre <dante.gamadessavre@gmail.com>
viclafargue
approved these changes
Nov 3, 2025
dantegd
approved these changes
Nov 3, 2025
Member
Author
|
/merge |
vardhan30016
pushed a commit
to vardhan30016/cuml
that referenced
this pull request
Nov 7, 2025
Closes rapidsai#5393 The problem was that `n_rows * n_cols > INT_MAX` causes an overflow. This PR switches to `int64` indexing in that case. Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Victor Lafargue (https://github.com/viclafargue) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#7421
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5393
The problem was that
n_rows * n_cols > INT_MAXcauses an overflow. This PR switches toint64indexing in that case.