FIX Allow prereleases when evaluating xfail conditions#6722
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from May 15, 2025
Merged
FIX Allow prereleases when evaluating xfail conditions#6722rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
Conversation
csadorf
added
improvement
csadorf
approved these changes
May 14, 2025
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test
cuml.accelwith the scikit-learn test suite we maintain a list of expected failures which can contain conditionals.This PR makes it so that a condition like
scikit-learn >= 1.6will evaluate to true when scikit-learn 1.7.0rc0 is installed. This is useful when we want to test a upcoming release of scikit-learn (or other packages) forcuml.accel.