Ensure compatibility with scikit-learn 1.7rc

[csadorf]

• Run the cuml test suite with scikit-learn version 1.7rc
• Run the scikit-learn test suite (version 1.7rc) with cuml.accel

[betatim]

With #6722, using a9fc610 and scikit-learn 1.7.0rc1 installed running ./run-tests.sh --disable-warnings --tb=auto -v -n 8 leads to 67 failures:

FAILED ../../../../ensemble/tests/test_bagging.py::test_bagging_with_metadata_routing[model0] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_bagging.py::test_bagging_with_metadata_routing[model1] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../decomposition/tests/test_sparse_pca.py::test_equivalence_components_pca_spca[42]
FAILED ../../../../ensemble/tests/test_common.py::test_ensemble_heterogeneous_estimators_behavior[stacking-classifier] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_common.py::test_ensemble_heterogeneous_estimators_behavior[voting-classifier] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_common.py::test_ensemble_heterogeneous_estimators_behavior[stacking-regressor] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_common.py::test_ensemble_heterogeneous_estimators_behavior[voting-regressor] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_forest.py::test_gridsearch[RandomForestClassifier] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../preprocessing/tests/test_target_encoder.py::test_fit_transform_not_associated_with_y_if_ordinal_categorical_is_not[42] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../tests/test_calibration.py::test_calibration_multiclass[0-False-sigmoid] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../tests/test_calibration.py::test_calibration_multiclass[0-False-isotonic] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../tests/test_calibration.py::test_calibration_multiclass[1-False-sigmoid] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../tests/test_calibration.py::test_calibration_multiclass[1-False-isotonic] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_forest.py::test_read_only_buffer[csr_matrix] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_forest.py::test_read_only_buffer[csr_array] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_classifier_iris[False-final_estimator1-3] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_classifier_iris[False-final_estimator1-cv1] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_classifier_iris[True-final_estimator1-3] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_classifier_iris[True-final_estimator1-cv1] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_classifier_drop_column_binary_classification - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_classifier_drop_estimator - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_drop_estimator - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_diabetes[False-final_estimator1-predict_params1-3] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_diabetes[False-final_estimator1-predict_params1-cv1] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_diabetes[True-final_estimator1-predict_params1-3] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_diabetes[True-final_estimator1-predict_params1-cv1] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_sparse_passthrough[coo_matrix] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_sparse_passthrough[coo_array] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_sparse_passthrough[csc_matrix] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_sparse_passthrough[csc_array] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_sparse_passthrough[csr_matrix] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_regressor_sparse_passthrough[csr_array] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_classifier_sparse_passthrough[coo_matrix] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_classifier_sparse_passthrough[csc_matrix] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_classifier_sparse_passthrough[csr_matrix] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_classifier_drop_binary_prob - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../model_selection/tests/test_search.py::test_search_cv_sample_weight_equivalence[estimator0] - AssertionError:
FAILED ../../../../tests/test_multioutput.py::test_multi_output_classification - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_stacking.py::test_stacking_final_estimator_attribute_error - AssertionError: Regex pattern did not match.
FAILED ../../../../ensemble/tests/test_voting.py::test_majority_label_iris[42] - ValueError:
FAILED ../../../../ensemble/tests/test_voting.py::test_weights_iris[42] - ValueError:
FAILED ../../../../ensemble/tests/test_voting.py::test_predict_proba_on_toy_problem - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_voting.py::test_gridsearch - ValueError:
FAILED ../../../../ensemble/tests/test_voting.py::test_parallel_fit[42] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_voting.py::test_voting_classifier_set_params[42] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_voting.py::test_estimator_weights_format[42] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../ensemble/tests/test_voting.py::test_transform[42] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_inferred_max_features_integer[0] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_inferred_max_features_integer[2] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_inferred_max_features_integer[4] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_inferred_max_features_integer[None] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_inferred_max_features_callable[<lambda>0] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_inferred_max_features_callable[<lambda>1] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_inferred_max_features_callable[<lambda>2] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_max_features_array_like[<lambda>] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_max_features_array_like[2] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_max_features_callable_data[<lambda>0] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_max_features_callable_data[<lambda>1] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_max_features_callable_data[<lambda>2] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_max_features - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../feature_selection/tests/test_from_model.py::test_threshold_and_max_features - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../tests/test_multioutput.py::test_multi_output_classes_[estimator1] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../tests/test_multioutput.py::test_multi_output_classes_[estimator2] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../tests/test_multioutput.py::test_classifier_chain_tuple_order[list] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../tests/test_multioutput.py::test_classifier_chain_tuple_order[array] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../tests/test_multioutput.py::test_classifier_chain_tuple_order[tuple] - cuml.common.exceptions.NotFittedError: Attempting to create treelite from un-fit forest.
FAILED ../../../../tests/test_multioutput.py::test_classifier_chain_tuple_invalid_order - AssertionError: Regex pattern did not match.
============================================== 67 failed, 35636 passed, 3829 skipped, 1189 xfailed, 71 xpassed, 4789 warnings in 214.40s (0:03:34) ==============================================

A lot of these seem to be due to "Attempting to create treelite from un-fit forest". Could this be a recent change in our random forest gpu/cpu code? Another idea is that scikit-learn clones unfitted models more often than before or some such?

[betatim]

I'll invest a few hours to see if I can move the random forests to the new proxy infrastructure. Both as a way of solving the above errors, to learn how the new infrastructure works and do a good dead for cuml by moving things to the new way.

[betatim]

Our optional dask CI job with 'oldest-deps' in #6734 fails because it installs scikit-learn 1.5.2, which means we can only install dask-ml=2024.4.4. I then "by hand" install scikit-learn 1.7.0rc1 which leads to failures. I think this is a red herring, the oldest-deps job should not use the newest version of scikit-learn. I think there is nothing to do here.

[betatim]

#6746 for tag fixups

[csadorf]

Closing this as completed.