Skip to content

Check if both ground truth and result are NaN in MSEObjectiveTest for RF #6387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 5 commits into from
Mar 14, 2025
Merged

Check if both ground truth and result are NaN in MSEObjectiveTest for RF #6387

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33060aa
Check if both ground truth and result are NaN
wphicks Mar 3, 2025
885e68e
Merge branch 'branch-25.04' into bug-mse_objective_nan
jcrist Mar 4, 2025
8a2e116
fix syntax error
csadorf Mar 5, 2025
a75c084
Merge branch 'branch-25.04' into bug-mse_objective_nan
wphicks Mar 5, 2025
827a609
Merge branch 'branch-25.04' into bug-mse_objective_nan
jcrist Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cpp/tests/sg/rf_test.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include <gtest/gtest.h>
#include <test_utils.h>

#include <cmath>
#include <cstddef>
#include <memory>
#include <random>
Expand Down Expand Up @@ -1208,7 +1209,11 @@ class ObjectiveTest : public ::testing::TestWithParam<ObjectiveTestParameters> {
NumLeftOfBin(cdf_hist, params.max_n_bins - 1),
NumLeftOfBin(cdf_hist, split_bin_index));

ASSERT_NEAR(ground_truth_gain, hypothesis_gain, params.tolerance);
// The gain may actually be NaN. If so, a comparison between the result and
// ground truth would yield false, even if they are both (correctly) NaNs.
if(!std::isnan(ground_truth_gain) || !std::isnan(hypothesis_gain) {
ASSERT_NEAR(ground_truth_gain, hypothesis_gain, params.tolerance);
}
}
};

Expand Down