Skip to content

Check if both ground truth and result are NaN in MSEObjectiveTest for RF#6387

Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.04from
wphicks:bug-mse_objective_nan
Mar 14, 2025
Merged

Check if both ground truth and result are NaN in MSEObjectiveTest for RF#6387
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.04from
wphicks:bug-mse_objective_nan

Conversation

@wphicks
Copy link
Copy Markdown
Contributor

@wphicks wphicks commented Mar 3, 2025

If both results are NaNs, pass the test rather than attempting to ASSERT_NEAR on NaN values.

@wphicks wphicks requested a review from a team as a code owner March 3, 2025 19:25
@wphicks wphicks requested review from lowener and tfeher March 3, 2025 19:25
@wphicks wphicks added bug Something isn't working non-breaking Non-breaking change labels Mar 3, 2025
@github-actions github-actions Bot added CUDA/C++ and removed bug Something isn't working non-breaking Non-breaking change labels Mar 3, 2025
@wphicks wphicks added bug Something isn't working non-breaking Non-breaking change labels Mar 4, 2025
@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Mar 14, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 67e0cc0 into rapidsai:branch-25.04 Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CUDA/C++ non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants