-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fallback to async-mr for the multithreaded parquet example
#22245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mhaseeb123
wants to merge
13
commits into
rapidsai:main
Choose a base branch
from
mhaseeb123:fix/use-async-mr-parquet-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−21
Open
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4af0c83
Use async mr for the parquet example for multithreading
mhaseeb123 0182f07
Use the benchmark util from hybrid scan
mhaseeb123 22699a3
Remove direct use of timer
mhaseeb123 954e475
No double printing of peak memory
mhaseeb123 e721632
Merge branch 'main' into fix/use-async-mr-parquet-example
mhaseeb123 d0cd2a4
Merge branch 'main' into fix/use-async-mr-parquet-example
mhaseeb123 31a3d6a
Merge branch 'main' into fix/use-async-mr-parquet-example
mhaseeb123 81b2a87
Fix
mhaseeb123 50f102b
Remove unnecessary headers
mhaseeb123 15b44c7
Minor
mhaseeb123 a4ae0c7
Minor - last one
mhaseeb123 1700246
Update cpp/examples/parquet_io/parquet_io_multithreaded.cpp
mhaseeb123 8eb44f3
Merge branch 'main' of https://github.com/rapidsai/cudf into fix/use-…
mhaseeb123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include "timer.hpp" | ||
|
|
||
| #include <cuda/iterator> | ||
|
|
||
| #include <algorithm> | ||
| #include <chrono> | ||
| #include <concepts> | ||
| #include <cstddef> | ||
| #include <iostream> | ||
|
|
||
| template <std::invocable F> | ||
| void benchmark(F&& f, std::size_t iterations) | ||
| { | ||
| auto total_time = double{0.0}; | ||
|
|
||
| std::for_each( | ||
| cuda::counting_iterator<std::size_t>{0}, cuda::counting_iterator{iterations}, [&](auto iter) { | ||
| timer timer; | ||
|
|
||
| f(); | ||
|
|
||
| auto elapsed_time_ms = | ||
| std::chrono::duration_cast<std::chrono::microseconds>(timer.elapsed()).count() / | ||
| double{1000.0}; | ||
|
|
||
| std::cout << "Iteration: " << iter << ", time: " << elapsed_time_ms << " ms\n"; | ||
|
|
||
| if (iterations == 1 or (iter != 0)) { total_time += elapsed_time_ms; } | ||
| }); | ||
|
|
||
| std::cout << "Average time (first iteration excluded if iterations > 1): " | ||
| << total_time / std::max<std::size_t>(1, iterations - 1) << " ms\n\n"; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied as is from
hybrid_scan_io/benchmark.hppfor self-contained example.