Fallback to async-mr for the multithreaded parquet example#22245
Open
mhaseeb123 wants to merge 13 commits intorapidsai:mainfrom
Open
Fallback to async-mr for the multithreaded parquet example#22245mhaseeb123 wants to merge 13 commits intorapidsai:mainfrom
async-mr for the multithreaded parquet example#22245mhaseeb123 wants to merge 13 commits intorapidsai:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mhaseeb123
commented
Apr 21, 2026
| @@ -0,0 +1,40 @@ | |||
| /* | |||
Member
Author
There was a problem hiding this comment.
Copied as is from hybrid_scan_io/benchmark.hpp for self-contained example.
mhaseeb123
commented
Apr 21, 2026
| */ | ||
|
|
||
| cuda::mr::any_resource<cuda::mr::device_accessible> create_memory_resource(bool is_pool_used) | ||
| std::shared_ptr<rmm::mr::device_memory_resource> create_memory_resource(bool is_pool_used) |
Member
Author
There was a problem hiding this comment.
Create async-mr when pool not used so that the multithreaded example version doesn't get by unnecessary syncs
mhaseeb123
added
3 - Ready for Review
Member
Author
|
Example Nsys profile from the |
bdice
reviewed
Apr 22, 2026
mhaseeb123
added
4 - Needs Review
vuule
approved these changes
May 1, 2026
mhaseeb123
commented
May 7, 2026
mhaseeb123
added
5 - Ready to Merge
…async-mr-parquet-example
Member
Author
|
/ok to test 8eb44f3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Construct an
async-mrwhenis_pool_usedisfalseso that the multithreaded parquet example runs without unnecessary synchronizations.Checklist