Convert np.dtype(str) to np.dtype(object) for cuDF#21354
Closed
mroeschke wants to merge 5 commits intorapidsai:mainfrom
Closed
Convert np.dtype(str) to np.dtype(object) for cuDF#21354mroeschke wants to merge 5 commits intorapidsai:mainfrom
mroeschke wants to merge 5 commits intorapidsai:mainfrom
Conversation
Contributor
Author
|
I think we need a different approach here. I think we need to only convert str to object when constructing a column but keep this in astype so closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cuML needed to work around a bug in rapidsai/cuml#7762 probably caused by #21281 where we were allowing
np.dtype("str")though to our column logic. Generally pandas doesn't have support for this type and converts tonp.dtype(object)to represent string instead which is what (IMO) cuDF should do too.I have historically though that cuDF should disallow
objecttype because it can mean "PyObject" type in pandas which we don't support. Now I'm starting to go backwards and think maybe cuDF should always just interpret it as string. For the "PyObject" cases in pandas, we can maybe just document this as an expected difference when usingcudf.pandasChecklist