Consolidate cudf-classic dtype validators to their own file and make them stricter#21281
Merged
rapids-bot[bot] merged 11 commits intorapidsai:mainfrom Feb 3, 2026
Merged
Conversation
mroeschke
added
Python
3 tasks
galipremsagar
approved these changes
Feb 3, 2026
Contributor
Author
|
/merge |
galipremsagar
pushed a commit
to galipremsagar/cudf
that referenced
this pull request
Feb 3, 2026
…them stricter (rapidsai#21281) python/cudf/cudf/utils/dtypes.py has become an assortment of dtype validation, conversions and constants. In preparation to support nullable pandas types natively (rapidsai#21229) I think it would be useful to break up this file into the described topic areas as we'll need to add more dtype logic handling soon. This PR creates `python/cudf/cudf/core/dtype/validators.py` which should hopefully be followed up by `constants.py` and `conversion.py`. I also made the logic in the functions moved to this file more strict as we should be strictly expecting dtype instances. Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: rapidsai#21281
betatim
added a commit
to betatim/cuml
that referenced
this pull request
Feb 4, 2026
See rapidsai/cudf#21281 for cudf changes.
rapids-bot Bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Feb 4, 2026
…7762) See rapidsai/cudf#21281 for cudf changes. This changed what cudf accepts as a valid dtype. Authors: - Tim Head (https://github.com/betatim) Approvers: - Simon Adorf (https://github.com/csadorf) URL: #7762
This was referenced Feb 5, 2026
dantegd
added a commit
to dantegd/cuml
that referenced
this pull request
Feb 17, 2026
…apidsai#7762) See rapidsai/cudf#21281 for cudf changes. This changed what cudf accepts as a valid dtype. Authors: - Tim Head (https://github.com/betatim) Approvers: - Simon Adorf (https://github.com/csadorf) URL: rapidsai#7762
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
python/cudf/cudf/utils/dtypes.py has become an assortment of dtype validation, conversions and constants. In preparation to support nullable pandas types natively (#21229) I think it would be useful to break up this file into the described topic areas as we'll need to add more dtype logic handling soon.
This PR creates
python/cudf/cudf/core/dtype/validators.pywhich should hopefully be followed up byconstants.pyandconversion.py. I also made the logic in the functions moved to this file more strict as we should be strictly expecting dtype instances.Checklist