DatetimeIndex.serialize() headers are msgpack serializable
#20714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapidsai#20709 and rapidsai#18778 recently changed DatetimeIndex to preserve `freq` in more places. This exposed an issue in how we serialize the properties of a DatetimeIndex: a `DateOffset` instance isn't serializable by msgpack. Distributed msgpack serialize the headers of messages, and so putting the `DateOffset` freq there caused issues. Instead of inserting the `DateOffset` itself, we insert the `kwds` that can be used to reconstruct it when deserializing. Closes rapidsai/dask-upstream-testing#88
galipremsagar
approved these changes
Nov 24, 2025
TomAugspurger
added
non-breaking
Contributor
|
/merge |
TomAugspurger
added a commit
to TomAugspurger/pygdf
that referenced
this pull request
Nov 26, 2025
…ze-datetimeinddex-freq `DatetimeIndex.serialize()` headers are msgpack serializable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#20709 and
#18778 recently changed DatetimeIndex to preserve
freqin more places.This exposed an issue in how we serialize the properties of a DatetimeIndex: a
DateOffsetinstance isn't serializable by msgpack. Distributed msgpack serialize the headers of messages, and so putting theDateOffsetfreq there caused issues.Instead of inserting the
DateOffsetitself, we insert thekwdsthat can be used to reconstruct it when deserializing.Note that this is targeted at
release/25.12, because that's where #18778 and #20709 landed and this is affecting dask shuffle operations.Closes rapidsai/dask-upstream-testing#88