Fix DatetimeIndex pickling #20709
Merged
Fix DatetimeIndex pickling #20709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We should get this fix into 25.12. It is a bug that is affecting ucxx's tests that rely on pickling (e.g. in this job), so we have to patch it somewhere and it might as well be at the source. |
galipremsagar
approved these changes
Nov 22, 2025
Matt711
approved these changes
Nov 22, 2025
TomAugspurger
added a commit
to TomAugspurger/pygdf
that referenced
this pull request
Nov 24, 2025
rapidsai#20709 and rapidsai#18778 recently changed DatetimeIndex to preserve `freq` in more places. This exposed an issue in how we serialize the properties of a DatetimeIndex: a `DateOffset` instance isn't serializable by msgpack. Distributed msgpack serialize the headers of messages, and so putting the `DateOffset` freq there caused issues. Instead of inserting the `DateOffset` itself, we insert the `kwds` that can be used to reconstruct it when deserializing. Closes rapidsai/dask-upstream-testing#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we added support for frequency handling in #18778, we did not account for preserving this property when pickling an index with a frequency.
Checklist