Force using old fmt in nvbench.#12067
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.12from Nov 4, 2022
Merged
Conversation
vyasr
added
bug
galipremsagar
approved these changes
Nov 4, 2022
3 tasks
Codecov ReportBase: 87.47% // Head: 88.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12067 +/- ##
================================================
+ Coverage 87.47% 88.09% +0.61%
================================================
Files 133 135 +2
Lines 21826 21997 +171
================================================
+ Hits 19093 19378 +285
+ Misses 2733 2619 -114
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3 tasks
robertmaynard
approved these changes
Nov 4, 2022
Contributor
|
@gpucibot merge |
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Nov 7, 2022
This is a port of rapidsai/cudf#12067. Original post: > The current version of nvbench is not compatible with the latest changes to fmt. This PR decouples us from needing to wait on upstreaming the compatibility changes to nvbench. These changes are necessary for building libcudf benchmarks until then. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - H. Thomson Comer (https://github.com/thomcom) URL: #783
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a port of #12064 to 22.12 to unblock CI because forward mergers are currently disabled.
Checklist