Force using old fmt in nvbench.#12064
Merged
msadang merged 1 commit intorapidsai:branch-22.10from Nov 3, 2022
Merged
Conversation
vyasr
added
bug
robertmaynard
approved these changes
Nov 3, 2022
Contributor
robertmaynard
left a comment
robertmaynard
left a comment
There was a problem hiding this comment.
Can we file an issue to track this so we don't forget?
Contributor
Author
|
Issue opened, #12065 |
bdice
reviewed
Nov 3, 2022
bdice
approved these changes
Nov 3, 2022
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Optional improvement to the comment. Probably not worth waiting 2 hours of CI for that.
Contributor
Author
|
Yeah I'll leave it as whatever cmake-format was happy with. |
Codecov ReportBase: 87.51% // Head: 87.51% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #12064 +/- ##
=============================================
Coverage 87.51% 87.51%
=============================================
Files 133 133
Lines 21826 21826
=============================================
Hits 19100 19100
Misses 2726 2726 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
This is a port of #12064 to 22.12 to unblock CI because forward mergers are currently disabled. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Robert Maynard (https://github.com/robertmaynard) URL: #12067
raydouglass
added a commit
that referenced
this pull request
Nov 4, 2022
Force using old fmt in nvbench. (#12064)
3 tasks
raydouglass
pushed a commit
that referenced
this pull request
Feb 15, 2023
This undoes #12064 and resolves #12065. Authors: - Vyas Ramasubramani (https://github.com/vyasr) - Robert Maynard (https://github.com/robertmaynard) Approvers: - Bradley Dice (https://github.com/bdice)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current version of nvbench is not compatible with the latest changes to fmt. This PR decouples us from needing to wait on upstreaming the compatibility changes to nvbench. These changes are necessary for building libcudf benchmarks until then.
Checklist