Install rapids-dependency-file-generator in test-wheel image#163
Merged
jameslamb merged 2 commits intorapidsai:mainfrom Jul 19, 2024
Merged
Install rapids-dependency-file-generator in test-wheel image#163jameslamb merged 2 commits intorapidsai:mainfrom
jameslamb merged 2 commits intorapidsai:mainfrom
Conversation
To allow testing the oldest dependencies, we wish to encode these into the `dependencies.yaml` file. To generate them at test time we then need `rapids-dependency-file-generator` to be installed and it seems easier to do this here.
14 tasks
jameslamb
approved these changes
Jul 18, 2024
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Thanks for this, I think it's totally fine to add to this image. Really appreciate the testing you did in rmm, that + my read of https://github.com/pyenv/pyenv/blob/master/COMMANDS.md makes me pretty confident in this change.
I put up one small suggestion... I'm going to apply it in the UI and then merge this. I strongly suspect you won't object, and it'd be easy enough to revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow testing the oldest dependencies, we wish to encode these into the
dependencies.yamlfile. To generate them at test time we then needrapids-dependency-file-generatorto be installed and it seems easier to do this here.xref rapidsai/build-planning#81
NOTE: I haven't tested this locally yet, the README snippet didn't run right away for me adding the equivalent here worked and the build log looks right