Skip to content

Update TPM2 session FIXME comments to document intentional implicit conversions #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

Update TPM2 session FIXME comments to document intentional implicit conversions #5118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/prov/tpm2/tpm2_session.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class BOTAN_UNSTABLE_API SessionHandle final {

~SessionHandle();

// NOLINTNEXTLINE(*-explicit-conversions) FIXME
// NOLINTNEXTLINE(*-explicit-conversions) Intentional: SessionHandle is a wrapper around ESYS_TR for C API interop
[[nodiscard]] operator ESYS_TR() && noexcept;

private:
Expand Down Expand Up @@ -165,7 +165,7 @@ class BOTAN_PUBLIC_API(3, 6) Session {
*/
class SessionBundle {
public:
// NOLINTNEXTLINE(*-explicit-conversions) FIXME
// NOLINTNEXTLINE(*-explicit-conversions) Intentional: Allows convenient single-session usage without explicit SessionBundle construction
SessionBundle(std::shared_ptr<Session> s1 = nullptr,
std::shared_ptr<Session> s2 = nullptr,
std::shared_ptr<Session> s3 = nullptr) :
Expand Down
Loading