Update TPM2 session FIXME comments to document intentional implicit conversions

[KaganCanSit]

Hello Botan Developer Team,

This pull request handling Clang-Tidy suppression in the tmp2_session.h file.

- Mark SessionBundle constructor as explicit
- Mark SessionHandle::operator ESYS_TR() as explicit

Source: C++ Core Guidlines C.46 By default, declare single-argument constructors explicit

UPDATE:
This PR updates FIXME comments in tpm2_session.h to properly document the intentional use of implicit conversions in TPM2 session wrapper classes.

• Updated SessionHandle::operator ESYS_TR() NOLINTNEXTLINE comment
• Updated SessionBundle constructor NOLINTNEXTLINE comment
• No functional changes to code behavior

If need any change or edits, please write comment to me. I fix.
Regards.

[coveralls]

coverage: 90.67% (-0.002%) from 90.672%
when pulling a8a77af on KaganCanSit:fixme/tmp2-explicit-conversions
into b88037c on randombit:master.

[reneme]

Unfortunately I have to oppose this PR. The implicit conversion operators and constructors were intentional for API ergonomics. The required adaptions in the implementation (adding static_cast and explicit constructor calls in many places) are exactly what they were meant to avoid. 🙂

[KaganCanSit]

Unfortunately I have to oppose this PR. The implicit conversion operators and constructors were intentional for API ergonomics. The required adaptions in the implementation (adding and explicit constructor calls in many places) are exactly what they were meant to avoid. 🙂static_cast

Alright. Then I'm retrieving the header contents here in a similar way to #5119.

• Remove explicit qualifiers.
• Update FIXME messages.
• Review the remaining conversions. Remove or edit “static_cast” contents.

Here, along with “SessionBundle,” most likely this entire branch will be reverted and only the FIXME messages will be updated, but I'm not sure. I'll look into it.

Thanks for review.

[KaganCanSit]

Unfortunately I have to oppose this PR. The implicit conversion operators and constructors were intentional for API ergonomics. The required adaptions in the implementation (adding and explicit constructor calls in many places) are exactly what they were meant to avoid. 🙂static_cast

Alright. Then I'm retrieving the header contents here in a similar way to #5119.

• Remove explicit qualifiers.
• Update FIXME messages.
• Review the remaining conversions. Remove or edit “static_cast” contents.

Here, along with “SessionBundle,” most likely this entire branch will be reverted and only the FIXME messages will be updated, but I'm not sure. I'll look into it.

Thanks for review.

Thank you for the feedback again. I apologize for the confusion.

I misunderstood the scope - I focused on the FIXME comments but incorrectly assumed the implicit conversions should be removed. I now understand they are intentional design choices for API ergonomics.

I updated this PR to only replace the FIXME comments in tpm2_session.h with proper explanations, and revert all implementation changes. And I change commit, PR text contents.

[reneme]

Thanks!