Skip to content

Conversation

@cnotv
Copy link
Member

@cnotv cnotv commented Nov 3, 2025

Description

Fixes #1184

  • Added unit test
  • Added section Priority Class Name for Priority Class Name
  • Bumped Rancher Components to 0.3.0-alpha.2
  • Added launcher options for VSCode

Test

  • Policy Servers
    • Edit
      • Navigate to /c/local/kubewarden/policies.kubewarden.io.policyserver/create#general
      • Open dropdown Priority Class Name
      • A list should appear
      • Select resource
      • Save
      • Edit resource
      • Value should still be present
    • List
      • Priority Class Name should be displayed

Video

Kapture.2025-11-05.at.16.52.46.mp4

@cnotv cnotv requested review from jvanz and kravciak November 3, 2025 16:46
@github-project-automation github-project-automation bot moved this to Pending review in Kubewarden Nov 3, 2025
@cnotv cnotv changed the title Feature: allow user to specify the priorityClassName for PolicyServe Feature: allow user to specify the priorityClassName for PolicyServer Nov 3, 2025
@kravciak
Copy link
Collaborator

kravciak commented Nov 4, 2025

I see same issues on rancher 2.13.0-alpha4:

  • I can't remove priority class after I select one (see "Clear" button on Service Account Name)
  • All priority classes are under undefined
Screenshot From 2025-11-04 12-11-04

@viccuad viccuad moved this from Pending review to In Progress in Kubewarden Nov 4, 2025
@cnotv
Copy link
Member Author

cnotv commented Nov 4, 2025

  • I can't remove priority class after I select one (see "Clear" button on Service Account Name)

That's unfortunately a dashboard issue to be handled separatedly and seems to affect also colors and a11y, but should not be complex

  • All priority classes are under undefined

Sorry I was still not able to set an instance of Rancher Docker. Taking a look with Helm.

@cnotv
Copy link
Member Author

cnotv commented Nov 4, 2025

@kravciak based on a recent comment, it looks like to clear the field is not an option ever used in the last 6 years in Rancher.

Investigating in how do we remove the values in these cases.

@kravciak
Copy link
Collaborator

kravciak commented Nov 5, 2025

Investigating in how do we remove the values in these cases.

Can't we just use the same Clear button/logic as we have on Service Account Name above?
It's not the best solution, but until it's implemented on rancher side...

Thanks for opening rancher/dashboard#15836

@cnotv
Copy link
Member Author

cnotv commented Nov 5, 2025

Investigating in how do we remove the values in these cases.

Can't we just use the same Clear button/logic as we have on Service Account Name above? It's not the best solution, but until it's implemented on rancher side...

Thanks for opening rancher/dashboard#15836

I am not entirely sure that's what is wanted, however it's just above like that as you said that we use that till an UX pattern is defined.
Thanks for the suggestion!

@cnotv
Copy link
Member Author

cnotv commented Nov 5, 2025

Investigating in how do we remove the values in these cases.

Can't we just use the same Clear button/logic as we have on Service Account Name above? It's not the best solution, but until it's implemented on rancher side...

Thanks for opening rancher/dashboard#15836

That part of code looks like uses another component. Trying to investigate on which case does it have to be used.

@cnotv
Copy link
Member Author

cnotv commented Nov 5, 2025

As per comment:
rancher/dashboard#15836 (comment)

Changing to ServiceNameSelect and trying out if it's working in the same way. I will update the tests as well

@cnotv
Copy link
Member Author

cnotv commented Nov 5, 2025

As per comment: rancher/dashboard#15836 (comment)

Changing to ServiceNameSelect and trying out if it's working in the same way. I will update the tests as well

As to get this functionality it starts to require way too many efforts and involve extra people as the 2 components API differ and the clear functionality is not exposed, I am just adding a button to what we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: allow user to specify the priorityClassName for PolicyServer

2 participants