Skip to content

Feature: allow user to specify the priorityClassName for PolicyServer #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Feature: allow user to specify the priorityClassName for PolicyServer #1335

wants to merge 9 commits into from

Conversation

@cnotv
Copy link
Member

@cnotv cnotv commented Oct 20, 2025 •
edited
Loading

Description

Fixes #1184

Added unit test and launcher options for VSCode.

Test

  • Policy Servers
    • Edit
      • Navigate to /c/local/kubewarden/policies.kubewarden.io.policyserver/create#general
      • Open dropdown Priority Class Name
      • A list should appear
      • Select resource
      • Save
      • Edit resource
      • Value should still be present
    • List
      • Priority Class Name should be displayed

Video

Kapture.2025-10-24.at.18.14.40.mp4

@github-project-automation github-project-automation bot moved this to Pending review in Kubewarden Oct 20, 2025
@flavio flavio removed this from Kubewarden Oct 21, 2025
@github-project-automation github-project-automation bot moved this to Pending review in Kubewarden Oct 24, 2025
@cnotv cnotv force-pushed the feature/1184-priority-class-name branch from 4b070eb to 3a2d102 Compare October 24, 2025 15:53
@cnotv cnotv marked this pull request as ready for review October 24, 2025 16:26
@cnotv cnotv requested a review from kravciak October 24, 2025 16:26
jvanz
jvanz reviewed Oct 24, 2025
View reviewed changes
Copy link
Member

@jvanz jvanz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but it's necessary to double check the failing tests

@kravciak
Copy link
Collaborator

kravciak commented Oct 25, 2025

Please rebase to use current tests, PR is based on code from April.

@kravciak kravciak self-assigned this Oct 25, 2025
kravciak
kravciak requested changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@kravciak kravciak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On rancher 2.13-alpha:

  • I can't remove priority class after I select one (see "Clear" button on Service Account Name)
  • All priority classes are under undefined
  • Could we rename Replicas group heading to High availability - so it would match default PS installer options?
image
Screenshot From 2025-10-27 09-24-02

@kravciak kravciak assigned cnotv and unassigned kravciak Oct 27, 2025
@flavio flavio moved this from Pending review to In Progress in Kubewarden Oct 28, 2025
@cnotv
Copy link
Member Author

cnotv commented Nov 3, 2025

  • Could we rename Replicas group heading to High availability - so it would match default PS installer options?

Please let's not mix up requirements.

@kravciak
Copy link
Collaborator

kravciak commented Nov 3, 2025

  • Could we rename Replicas group heading to High availability - so it would match default PS installer options?

Please let's not mix up requirements.

Ok, then please add label so priority class is not under replicas.

@cnotv
Copy link
Member Author

cnotv commented Nov 3, 2025 •
edited
Loading

@kravciak for the records: Rancher head breaks when I create it with Docker so I cannot reproduce eventual new BE issues created between the moment of the PR and my absence.

We need to reproduce your issue in order to address that.

Clearable functionality seems to be broken on dashboard and I filed a separated issue for it. API of the component will be inherited on version bump.

@cnotv cnotv force-pushed the feature/1184-priority-class-name branch from 6a3c7af to ee0b7e3 Compare November 3, 2025 16:16
@cnotv
Copy link
Member Author

cnotv commented Nov 3, 2025

After doing rebase of Kubewarden, I still do not encounter any issue.
Waiting to find a Rancher dashboard image which works.

Kapture.2025-11-03.at.17.34.24.mp4

@cnotv
Copy link
Member Author

cnotv commented Nov 3, 2025

I just realized to have been pushing to the rancher remote, so I created a new PR: #1348
This branch can be removed.

@cnotv cnotv closed this Nov 3, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kubewarden Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvanz jvanz jvanz left review comments

@kravciak kravciak kravciak requested changes

Assignees

@cnotv cnotv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: allow user to specify the priorityClassName for PolicyServer

4 participants

@cnotv @kravciak @jvanz