feat(mainnet): introduce assets

[al3mart]

Adds assets into mainnet runtime:

• pallet_assets
• pallet_nfts

Refactors ProxyType such that assets calls are taken into account.

---

• Include pallet_assets in the runtime
• Include pallet_nfts in the runtime
• Review pallet_assets configuration
• Review pallet_nfts configuration
• Implement configuration unit tests for pallet_assets
• Implement configuration unit tests for pallet_nfts
• Include asset specific proxy types in mainnet runtime.

---

Relevant configuration:

• pallet-assets

// Accounts for `Asset` max size.
pub const AssetDeposit: Balance = deposit(1, 210);
// Enough to keep the balance in state / 100.
pub const AssetAccountDeposit: Balance = deposit(1, 16) / 100;
// Accounts for the key length + 
// Value max length without name and symbol, which are accounted per byte. 
pub const MetadataDepositBase: Balance = deposit(1, 38);

Deposit costs:

Deposit	Original Cost (DOT)	Reduced Cost (DOT)
AssetDeposit	0.2021	Not Updated
AssetAccountDeposit	0.20016	0.0020016
AssetsApprovalDesposit	0.1	Not Updated
MetadataDepositBase	0.20038	Not Updated
PerByte	1e-05	Not Updated

The amount of funds that must be reserved for a non-provider asset account to be maintained has been reduced by a factor of 100.

• pallet-nfts

// All features enabled.
pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
// Accounts for `AccountBalance` max size.
// Key = 68 bytes (4+16+32+16), Value = 52 bytes (4+32+16)
pub const NftsCollectionBalanceDeposit: Balance = deposit(1, 120) / 100;
// Accounts for state from `Collection` +
// `CollectionRoleOf` +
// `CollectionConfigOf` +
// `CollectionAccount`
// Refer to `ensure_collection_deposit` test for specifics.
pub const NftsCollectionDeposit: Balance = deposit(4, 294);
// Accounts for `CollectionApprovals` max size.
// Key = 116 bytes (4+16+32+16+32+16), Value = 21 bytes (1+4+16)
pub const NftsCollectionApprovalDeposit: Balance = deposit(1, 137) / 100;
// Accounts for `Item` storage item max size.
pub const NftsItemDeposit: Balance = deposit(1, 861) / 100;
// Key = max(size_of(item_metadata_key), size_of(collection_metadata_key)) + Balance: 16 bytes
pub const NftsMetadataDepositBase: Balance = deposit(1, 56) / 100;
// Accounts for key size of `Attribute`.
pub const NftsAttributeDepositBase: Balance = deposit(1, 89) / 100;

Deposit Costs:

Deposit	Original Cost (DOT)	Reduced Cost (DOT)
NftsCollectionBalanceDeposit	0.2012	0.002012
NftsCollectionDeposit	0.80294	Not Updated
NftsCollectionApprovalDeposit	0.20137	0.0020137
NftsItemDeposit	0.20861	0.0020861
NftsMetadataDepositBase	0.20056	0.0020056
NftsAttributeDepositBase	0.20089	0.0020089
PerByte	1e-05	Not Updated

I've lowered certain deposits for NFTs such that the deposit cost of creating a collection remains as it has been calculated (it didn't seem high given the current pricing) but lowers the the deposit costs for the rest of actions by a factor of 100. This should easy the usage of the created assets.

I'm not that concerned about the rest of deposits myself, but happy to hear different opinions.

Relevant reference to tackle these numbers: RFC#45

[sc-2764]

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.63049% with 44 lines in your changes missing coverage. Please review.

Project coverage is 76.07%. Comparing base (cae5b19) to head (098a035).

Files with missing lines	Patch %	Lines
runtime/mainnet/src/apis.rs	0.00%	44 Missing ⚠️

@@                         Coverage Diff                         @@
##           al3mart/refactor-mainnet-config     #465      +/-   ##
===================================================================
+ Coverage                            75.80%   76.07%   +0.26%     
===================================================================
  Files                                   83       84       +1     
  Lines                                17143    17514     +371     
  Branches                             17143    17514     +371     
===================================================================
+ Hits                                 12996    13323     +327     
- Misses                                3885     3928      +43     
- Partials                               262      263       +1     

Files with missing lines	Coverage Δ
runtime/mainnet/src/config/assets.rs	100.00% <100.00%> (ø)
runtime/mainnet/src/lib.rs	66.23% <ø> (ø)
runtime/mainnet/src/apis.rs	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

[Daanvdplas]

Stopped reviewing while reviewing the nfts configuration. This is not audited yet and we should use the SDK's pallet nfts.

Can we change this and then I will finish the review.

[Daanvdplas]

Why no numbers backing the amount like done for all other deposit parameters? As well as the test below.

[al3mart]

Well, ExistentialDeposit is a number, and in many of the cases the "number" is calculated and then compared with the one declared above. So I didn't consider it necessary.

[Daanvdplas]

I don't understand :)

[al3mart]

I did add asserts for the concrete values anyway 👍

[Daanvdplas]

It would be nice to explain which keys and values are used for this calculation and why. Makes it much easier to review and understand when we have to come back to it.

[al3mart]

098a035

[Daanvdplas]

PR looking good, some final fixes and then good to go!

[Daanvdplas]

Great job on the PR and also the quick response to getting this finished!

[peterwht]

🚀🚀