refactor(mainnet): system config by al3mart · Pull Request #442 · r0gue-io/pop-node

al3mart · 2025-01-21T00:43:45Z

Creates system config module including:

frame_system

Notable configuration items are:

SS58

pub const SS58Prefix: u16 = 0;

frame_system

extensionsWeightInfo needs to be configured after benchmark is run. Configured to use default weights a the moment.
No calls area filtered.
No permanent migrations included at genesis.

type BaseCallFilter = Everything;
type ExtensionsWeightInfo = (); // Needs to be updated after benchmarks
type Lookup = AccountIdLookup<Self::AccountId, ()>;
type SingleBlockMigrations = ();

parachain_system

type CheckAssociatedRelayNumber = RelayNumberMonotonicallyIncreases;
type ReservedDmpWeight = MAXIMUM_BLOCK_WEIGHT.saturating_div(4);;
type ReservedXcmpWeight = MAXIMUM_BLOCK_WEIGHT.saturating_div(4);;
type SelectCore = cumulus_pallet_parachain_system::LookaheadCoreSelector<Runtime>;

pallet_timestamp

type MinimumPeriod = ConstU64<0>;

[sc-2205]

codecov-commenter · 2025-01-30T20:03:13Z

Codecov Report

Attention: Patch coverage is 97.96512% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (al3mart/refactor-mainnet-config@b71c3a8). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
runtime/mainnet/src/config/system.rs	97.96%	7 Missing ⚠️

@@                        Coverage Diff                         @@
##             al3mart/refactor-mainnet-config     #442   +/-   ##
==================================================================
  Coverage                                   ?   72.01%           
==================================================================
  Files                                      ?       76           
  Lines                                      ?    14266           
  Branches                                   ?    14266           
==================================================================
  Hits                                       ?    10273           
  Misses                                     ?     3726           
  Partials                                   ?      267

Files with missing lines	Coverage Δ
node/src/command.rs	`0.00% <ø> (ø)`
runtime/mainnet/src/lib.rs	`64.51% <ø> (ø)`
runtime/mainnet/src/config/system.rs	`97.96% <97.96%> (ø)`

al3mart · 2025-01-30T20:47:58Z

runtime/mainnet/src/config/system.rs

+	/// The weight of database operations that the runtime can invoke.
+	type DbWeight = RocksDbWeight;
+	/// Weight information for the extensions of this pallet.
+	type ExtensionsWeightInfo = ();


To be updated once we have run benchmarks,

al3mart · 2025-01-30T20:48:30Z

runtime/mainnet/src/config/system.rs

+	}
+
+	#[test]
+	#[ignore]


Remove ignore after benchmarks results are included in the configuration of frame_system.

runtime/mainnet/src/config/mod.rs

runtime/mainnet/src/config/system.rs

Daanvdplas

A few comments but overall looking good!

runtime/mainnet/src/lib.rs

Daanvdplas · 2025-02-03T17:32:47Z

runtime/mainnet/src/config/system.rs

+parameter_types! {
+	pub const Version: RuntimeVersion = VERSION;
+	pub const SS58Prefix: u16 = 0;
+	// This part is copied from Substrate's `bin/node/runtime/src/lib.rs`.


Seems outdated from a template

This was indeed outdated: 003efa0

Daanvdplas · 2025-02-03T17:35:58Z

runtime/mainnet/src/lib.rs

-	type ReservedDmpWeight = ReservedDmpWeight;
-	type ReservedXcmpWeight = ReservedXcmpWeight;
-	type RuntimeEvent = RuntimeEvent;
-	type SelectCore = cumulus_pallet_parachain_system::DefaultCoreSelector<Runtime>;


Why are we switching here to LookaheadSelector?

because our async backing configuration is meant to be used with LookAhead.

Nothing is wrong with using the default selector, as in it will work.

So it is the same?

runtime/mainnet/src/config/system.rs

al3mart · 2025-02-04T11:44:35Z

Rebased after changes being merged into base branch

Daanvdplas

Nicely done!

Suggested small changes to the module docs as they are repetitive and the usage of pop is necessary as we are in the runtime module of the pop-node repository.

runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

* refactor(mainnet): add frame_system to system * test(mainnet): add pallet_system test * fix(mainnet): rebase fixes * fix(system): bring missing types in scope * refactor(system): add cumulus_parachain_system to system config module * test(system): add cumulus_parachain_system tests * refactor(system): add parachain_info into system config module * refactor(system): add pallet_timestamp into system config module * style(system): add ConsensusHook comment * refactor(system): separate tests by module * docs(system): document public config modules * fix(system): allow unused_imports to remove Executive warning * refactor(system): reintroduce FilteredCalls * style(system): get rid of test prefixes * style(system): relocate max_block_weigth comment * test(system): check for Hash type config * docs(system): amend outdated comments * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

* refactor(mainnet): rebase changes * chore(mainnet): update Cargo.lock * refactor(mainnet): utility config (#438) * refactor(mainnet): add pallet_multisig to utility * test(mainnet): add pallet_multisig tests * refactor(mainnet): add pallet_utility to utility * test(mainnet): add pallet_utility tests * refactor(mainnet): add pallet_preimage to utility * test(mainnet): add pallet_preimage tests * refactor(mainnet): add pallet_scheduler to utility * test(mainnet): add pallet_scheduler tests * refactor(mainnet): system config (#442) * refactor(mainnet): add frame_system to system * test(mainnet): add pallet_system test * fix(mainnet): rebase fixes * fix(system): bring missing types in scope * refactor(system): add cumulus_parachain_system to system config module * test(system): add cumulus_parachain_system tests * refactor(system): add parachain_info into system config module * refactor(system): add pallet_timestamp into system config module * style(system): add ConsensusHook comment * refactor(system): separate tests by module * docs(system): document public config modules * fix(system): allow unused_imports to remove Executive warning * refactor(system): reintroduce FilteredCalls * style(system): get rid of test prefixes * style(system): relocate max_block_weigth comment * test(system): check for Hash type config * docs(system): amend outdated comments * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * refactor(mainnet): collation config (#439) * refactor(mainnet): add pallet_authorship to collation * test(mainnet): add pallet_auhtorship test * refactor(mainnet): add pallet_aura to collation * test(mainnet): add pallet_aura tests * refactor(mainnet): add collator_selection to collation * test(mainnet): add collator_selection tests * refactor(mainnet): add pallet_session & aura_ext to collation * test(mainnet): add pallet_session tests * chore(aura): MaxAuthorities matches max possible blocks produced * remove unnused imports * style(collation): order tests following pallet config * style(collation): remove unnecessary qualifications * style(collation): max_authorities_is_3600 * style(collation): reorg definition in session_keys_provided_by_aura test * style(collation): better Period comment * style(collation): clarify session::SessionHandler comment * refactor(collation): separate tests in modules by pallet * style(collation): Explain SessionHandler config fixes after rebase * style(collation): remove prefixes from tests * style(collation): Period comment was not helpful changes after rebase * refactor(xcm): add pallet_message_queue into xcm config module * test(xcm): add message_queue tests * test(xcm): test location, transactor and barrier type definitions * refactor(xcm): include pallet_xcmp_queue into xcm config module * test(xcm): add pallet_xcmp_queue configuration tests * test(xcm): add xcm_executor configuration tests * test(xcm): adding pallet_xcm config tests * fix(xcm): typo fix(xcm): XcmReserveTransferFilter is Everything * refactor(xcm): use unitype for MaxRemoteLockConsumers * style(xcm): tests separated in modules * style(xcm): better naming for XcmTeleportFilter test * style(xcm): test naming and order * docs(xcm): clarifying comments for specific xcmp_queueu types * style(xcm): typo * style(xcm): better name for reserves tests * refactor(xcm): Use `NativeAssetFrom<T>` as `XcmReserveTransferFilter` (#459) * refactor(xcm): Use NativeAssetFrom<T> as XcmReserveTransferFilter style:fmt * fix(xcm): NativeAssetFrom<AssetHub> filters everything but DOT from AH * fix(xcm): XcmReserveTransferFilter filters only by asset fix changes after rebase fmt * fix(xcm): remove waived locations (#456) * fix(xcm): no locations are waived * test(xcm): improved waived_location test changes after rebase * style(xcm): clarify that we are not waiving fees for any location * fix(xcm): charge delivery fees (#457) * resolve rebase conflicts * fix(xcm): reserve_transfer_native_asset_from_para_to_system_para accounts for delivery fees * fix(integration-tests): handle delivery_fees only with mainnet feature on fmt after rebase fmt changes after rebase fmt fmt * test(xcm): address feedback from #459 typos AssetFilter * style(xcm): locate reserve tests within executor lint * fix(integration-test): improve tests & remove feature gated compilation unnecessary Fungibles * refactor: integration tests mainnet xcm (#466) * refactor: integration tests mainnet xcm * fix: remove unused ED rebase fmt fmt * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * refactor(xcm): use TreasuryAccount from monetary * chore(xcm): unused imports * chore(xcm): amend test modules * chore(integration-tests): amend reserve_transfer_native_asset_from_para_to_system * chore(xcm): divive reserve filter test in two * chore(xcm): fmt * style(integration-tests): fix unwanted indentation * test(xcm): more focused unit tests * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * fix(test): amend suggestions --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

* refactor(mainnet): add frame_system to system * test(mainnet): add pallet_system test * fix(mainnet): rebase fixes * fix(system): bring missing types in scope * refactor(system): add cumulus_parachain_system to system config module * test(system): add cumulus_parachain_system tests * refactor(system): add parachain_info into system config module * refactor(system): add pallet_timestamp into system config module * style(system): add ConsensusHook comment * refactor(system): separate tests by module * docs(system): document public config modules * fix(system): allow unused_imports to remove Executive warning * refactor(system): reintroduce FilteredCalls * style(system): get rid of test prefixes * style(system): relocate max_block_weigth comment * test(system): check for Hash type config * docs(system): amend outdated comments * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

* refactor(mainnet): rebase changes * chore(mainnet): update Cargo.lock * refactor(mainnet): utility config (#438) * refactor(mainnet): add pallet_multisig to utility * test(mainnet): add pallet_multisig tests * refactor(mainnet): add pallet_utility to utility * test(mainnet): add pallet_utility tests * refactor(mainnet): add pallet_preimage to utility * test(mainnet): add pallet_preimage tests * refactor(mainnet): add pallet_scheduler to utility * test(mainnet): add pallet_scheduler tests * refactor(mainnet): system config (#442) * refactor(mainnet): add frame_system to system * test(mainnet): add pallet_system test * fix(mainnet): rebase fixes * fix(system): bring missing types in scope * refactor(system): add cumulus_parachain_system to system config module * test(system): add cumulus_parachain_system tests * refactor(system): add parachain_info into system config module * refactor(system): add pallet_timestamp into system config module * style(system): add ConsensusHook comment * refactor(system): separate tests by module * docs(system): document public config modules * fix(system): allow unused_imports to remove Executive warning * refactor(system): reintroduce FilteredCalls * style(system): get rid of test prefixes * style(system): relocate max_block_weigth comment * test(system): check for Hash type config * docs(system): amend outdated comments * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * refactor(mainnet): collation config (#439) * refactor(mainnet): add pallet_authorship to collation * test(mainnet): add pallet_auhtorship test * refactor(mainnet): add pallet_aura to collation * test(mainnet): add pallet_aura tests * refactor(mainnet): add collator_selection to collation * test(mainnet): add collator_selection tests * refactor(mainnet): add pallet_session & aura_ext to collation * test(mainnet): add pallet_session tests * chore(aura): MaxAuthorities matches max possible blocks produced * remove unnused imports * style(collation): order tests following pallet config * style(collation): remove unnecessary qualifications * style(collation): max_authorities_is_3600 * style(collation): reorg definition in session_keys_provided_by_aura test * style(collation): better Period comment * style(collation): clarify session::SessionHandler comment * refactor(collation): separate tests in modules by pallet * style(collation): Explain SessionHandler config fixes after rebase * style(collation): remove prefixes from tests * style(collation): Period comment was not helpful changes after rebase * refactor(xcm): add pallet_message_queue into xcm config module * test(xcm): add message_queue tests * test(xcm): test location, transactor and barrier type definitions * refactor(xcm): include pallet_xcmp_queue into xcm config module * test(xcm): add pallet_xcmp_queue configuration tests * test(xcm): add xcm_executor configuration tests * test(xcm): adding pallet_xcm config tests * fix(xcm): typo fix(xcm): XcmReserveTransferFilter is Everything * refactor(xcm): use unitype for MaxRemoteLockConsumers * style(xcm): tests separated in modules * style(xcm): better naming for XcmTeleportFilter test * style(xcm): test naming and order * docs(xcm): clarifying comments for specific xcmp_queueu types * style(xcm): typo * style(xcm): better name for reserves tests * refactor(xcm): Use `NativeAssetFrom<T>` as `XcmReserveTransferFilter` (#459) * refactor(xcm): Use NativeAssetFrom<T> as XcmReserveTransferFilter style:fmt * fix(xcm): NativeAssetFrom<AssetHub> filters everything but DOT from AH * fix(xcm): XcmReserveTransferFilter filters only by asset fix changes after rebase fmt * fix(xcm): remove waived locations (#456) * fix(xcm): no locations are waived * test(xcm): improved waived_location test changes after rebase * style(xcm): clarify that we are not waiving fees for any location * fix(xcm): charge delivery fees (#457) * resolve rebase conflicts * fix(xcm): reserve_transfer_native_asset_from_para_to_system_para accounts for delivery fees * fix(integration-tests): handle delivery_fees only with mainnet feature on fmt after rebase fmt changes after rebase fmt fmt * test(xcm): address feedback from #459 typos AssetFilter * style(xcm): locate reserve tests within executor lint * fix(integration-test): improve tests & remove feature gated compilation unnecessary Fungibles * refactor: integration tests mainnet xcm (#466) * refactor: integration tests mainnet xcm * fix: remove unused ED rebase fmt fmt * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * refactor(xcm): use TreasuryAccount from monetary * chore(xcm): unused imports * chore(xcm): amend test modules * chore(integration-tests): amend reserve_transfer_native_asset_from_para_to_system * chore(xcm): divive reserve filter test in two * chore(xcm): fmt * style(integration-tests): fix unwanted indentation * test(xcm): more focused unit tests * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * fix(test): amend suggestions --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

* refactor(mainnet): add governance & pallet_sudo tests (#443) * refactor(mainnet): add governance & pallet_sudo tests * refactor(sudo): sudo account defined in governance & unit test fix(governance): make governance mod public & better sudo declaration * refactor(mainnet): utility config (#438) * refactor(mainnet): add pallet_multisig to utility * test(mainnet): add pallet_multisig tests * refactor(mainnet): add pallet_utility to utility * test(mainnet): add pallet_utility tests * refactor(mainnet): add pallet_preimage to utility * test(mainnet): add pallet_preimage tests * refactor(mainnet): add pallet_scheduler to utility * test(mainnet): add pallet_scheduler tests * refactor(mainnet): pallet_proxy config & tests (#441) * refactor(mainnet): pallet_proxy config & tests * style(proxy): tests follow config order * refactor(proxy): remove asset related ProxyTypes * refactor(proxy): update ProxyDepositBase price * refactor(proxy): revert d3bfc6c and redefine ProxyType for mainnet typo * fix(proxy): amend proxy_has_deposit_base test * docs(proxy): Clarify new ProxyType definition * docs(proxy): add is_superset comments * test(proxy): clarify deposit byte size lenght * refactor(mainnet): system config (#442) * refactor(mainnet): add frame_system to system * test(mainnet): add pallet_system test * fix(mainnet): rebase fixes * fix(system): bring missing types in scope * refactor(system): add cumulus_parachain_system to system config module * test(system): add cumulus_parachain_system tests * refactor(system): add parachain_info into system config module * refactor(system): add pallet_timestamp into system config module * style(system): add ConsensusHook comment * refactor(system): separate tests by module * docs(system): document public config modules * fix(system): allow unused_imports to remove Executive warning * refactor(system): reintroduce FilteredCalls * style(system): get rid of test prefixes * style(system): relocate max_block_weigth comment * test(system): check for Hash type config * docs(system): amend outdated comments * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * refactor(mainnet): monetary config (#440) * refactor(mainnet): pallet_balances & fee constants * test(mainnet): add pallet_balances tests * refactor(mainnet): add pallet_transaction_payment to monetary config * test(mainnet): add transaction_payment tests * fix(mainnet): rebase fixes * fix(monetary): don't burn dust * refactor(monetary): use treasury account instead of sudo remove extra clone * refactor(monetary): use existential_deposit instead of UNIT in dust test * refactor(monetary): Don't use DOLLARS & CENTS is defined in terms of UNITS * fix(monetary): missing doc for fn deposit * docs(monetary): remove src from docs * docs(monetary): update TransactionByteFee comments * refactor(monetary): reorg tests into modules * style(monetary): remove confussing comment * style(monetar): remove prefixes from tests changes after rebase more changes after reabse * refactor(mainnet): collation config (#439) * refactor(mainnet): add pallet_authorship to collation * test(mainnet): add pallet_auhtorship test * refactor(mainnet): add pallet_aura to collation * test(mainnet): add pallet_aura tests * refactor(mainnet): add collator_selection to collation * test(mainnet): add collator_selection tests * refactor(mainnet): add pallet_session & aura_ext to collation * test(mainnet): add pallet_session tests * chore(aura): MaxAuthorities matches max possible blocks produced * remove unnused imports * style(collation): order tests following pallet config * style(collation): remove unnecessary qualifications * style(collation): max_authorities_is_3600 * style(collation): reorg definition in session_keys_provided_by_aura test * style(collation): better Period comment * style(collation): clarify session::SessionHandler comment * refactor(collation): separate tests in modules by pallet * style(collation): Explain SessionHandler config fixes after rebase * style(collation): remove prefixes from tests * style(collation): Period comment was not helpful changes after rebase * style(utility): better test structure style(utility): fmt rebase fmt fmt * refactor(mainnet): xcm config (#455) * refactor(mainnet): rebase changes * chore(mainnet): update Cargo.lock * refactor(mainnet): utility config (#438) * refactor(mainnet): add pallet_multisig to utility * test(mainnet): add pallet_multisig tests * refactor(mainnet): add pallet_utility to utility * test(mainnet): add pallet_utility tests * refactor(mainnet): add pallet_preimage to utility * test(mainnet): add pallet_preimage tests * refactor(mainnet): add pallet_scheduler to utility * test(mainnet): add pallet_scheduler tests * refactor(mainnet): system config (#442) * refactor(mainnet): add frame_system to system * test(mainnet): add pallet_system test * fix(mainnet): rebase fixes * fix(system): bring missing types in scope * refactor(system): add cumulus_parachain_system to system config module * test(system): add cumulus_parachain_system tests * refactor(system): add parachain_info into system config module * refactor(system): add pallet_timestamp into system config module * style(system): add ConsensusHook comment * refactor(system): separate tests by module * docs(system): document public config modules * fix(system): allow unused_imports to remove Executive warning * refactor(system): reintroduce FilteredCalls * style(system): get rid of test prefixes * style(system): relocate max_block_weigth comment * test(system): check for Hash type config * docs(system): amend outdated comments * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * refactor(mainnet): collation config (#439) * refactor(mainnet): add pallet_authorship to collation * test(mainnet): add pallet_auhtorship test * refactor(mainnet): add pallet_aura to collation * test(mainnet): add pallet_aura tests * refactor(mainnet): add collator_selection to collation * test(mainnet): add collator_selection tests * refactor(mainnet): add pallet_session & aura_ext to collation * test(mainnet): add pallet_session tests * chore(aura): MaxAuthorities matches max possible blocks produced * remove unnused imports * style(collation): order tests following pallet config * style(collation): remove unnecessary qualifications * style(collation): max_authorities_is_3600 * style(collation): reorg definition in session_keys_provided_by_aura test * style(collation): better Period comment * style(collation): clarify session::SessionHandler comment * refactor(collation): separate tests in modules by pallet * style(collation): Explain SessionHandler config fixes after rebase * style(collation): remove prefixes from tests * style(collation): Period comment was not helpful changes after rebase * refactor(xcm): add pallet_message_queue into xcm config module * test(xcm): add message_queue tests * test(xcm): test location, transactor and barrier type definitions * refactor(xcm): include pallet_xcmp_queue into xcm config module * test(xcm): add pallet_xcmp_queue configuration tests * test(xcm): add xcm_executor configuration tests * test(xcm): adding pallet_xcm config tests * fix(xcm): typo fix(xcm): XcmReserveTransferFilter is Everything * refactor(xcm): use unitype for MaxRemoteLockConsumers * style(xcm): tests separated in modules * style(xcm): better naming for XcmTeleportFilter test * style(xcm): test naming and order * docs(xcm): clarifying comments for specific xcmp_queueu types * style(xcm): typo * style(xcm): better name for reserves tests * refactor(xcm): Use `NativeAssetFrom<T>` as `XcmReserveTransferFilter` (#459) * refactor(xcm): Use NativeAssetFrom<T> as XcmReserveTransferFilter style:fmt * fix(xcm): NativeAssetFrom<AssetHub> filters everything but DOT from AH * fix(xcm): XcmReserveTransferFilter filters only by asset fix changes after rebase fmt * fix(xcm): remove waived locations (#456) * fix(xcm): no locations are waived * test(xcm): improved waived_location test changes after rebase * style(xcm): clarify that we are not waiving fees for any location * fix(xcm): charge delivery fees (#457) * resolve rebase conflicts * fix(xcm): reserve_transfer_native_asset_from_para_to_system_para accounts for delivery fees * fix(integration-tests): handle delivery_fees only with mainnet feature on fmt after rebase fmt changes after rebase fmt fmt * test(xcm): address feedback from #459 typos AssetFilter * style(xcm): locate reserve tests within executor lint * fix(integration-test): improve tests & remove feature gated compilation unnecessary Fungibles * refactor: integration tests mainnet xcm (#466) * refactor: integration tests mainnet xcm * fix: remove unused ED rebase fmt fmt * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * refactor(xcm): use TreasuryAccount from monetary * chore(xcm): unused imports * chore(xcm): amend test modules * chore(integration-tests): amend reserve_transfer_native_asset_from_para_to_system * chore(xcm): divive reserve filter test in two * chore(xcm): fmt * style(integration-tests): fix unwanted indentation * test(xcm): more focused unit tests * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * fix(test): amend suggestions --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * feat(mainnet): introduce assets (#465) * refactor(mainnet): include assets fmt refactor(collator): not necessary import * test(assets): add nfts config unit tests * refactor(proxy): Add assets & smart contract proxy type * refactor(assets): implement nfts runtime api * fix(pallet-nfts-api): workspace linters are not defined * docs(assets): clarify deposits * chore(proxy): improve usage of references * docs(assets): update src reference * chore(assets): update MetadataDepositBase * docs(assets): remove TODOs * refactor(proxy): revert SmartContract ProxyType * revert: e614927 * style(Cargo): revert format changes on dep comments * chore(assets): apply feedback to tests * chore(assets): removed unused type * revert: fb92342 This reverts commit fb92342. * docs(assets): better comments * chore(assets): lower nfts deposit costs * chore(assets): reduced deposit cost for AssetAccountDeposit * chore(assets): use SDK's pallet_nfts * chore(assets): better deposits & fmt Cargo * chore(assets): better comments * chore(assets): more explicit comments for deposits * chore(assets): provide src for NftsCollectionDeposit deposit * chore(assets): apply feedback * chore(monetary): clean unnecessary comments * chore(utility): make deposit calc explicit. (#469) chore(utility): explicit deposit justification rebase fixes * chore(proxy): reintroduce Asset related proxy types * syle(proxy): Clarify proxy test comments --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

* refactor(mainnet): rebase changes * chore(mainnet): update Cargo.lock * refactor(mainnet): utility config (#438) * refactor(mainnet): add pallet_multisig to utility * test(mainnet): add pallet_multisig tests * refactor(mainnet): add pallet_utility to utility * test(mainnet): add pallet_utility tests * refactor(mainnet): add pallet_preimage to utility * test(mainnet): add pallet_preimage tests * refactor(mainnet): add pallet_scheduler to utility * test(mainnet): add pallet_scheduler tests * refactor(mainnet): system config (#442) * refactor(mainnet): add frame_system to system * test(mainnet): add pallet_system test * fix(mainnet): rebase fixes * fix(system): bring missing types in scope * refactor(system): add cumulus_parachain_system to system config module * test(system): add cumulus_parachain_system tests * refactor(system): add parachain_info into system config module * refactor(system): add pallet_timestamp into system config module * style(system): add ConsensusHook comment * refactor(system): separate tests by module * docs(system): document public config modules * fix(system): allow unused_imports to remove Executive warning * refactor(system): reintroduce FilteredCalls * style(system): get rid of test prefixes * style(system): relocate max_block_weigth comment * test(system): check for Hash type config * docs(system): amend outdated comments * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * refactor(mainnet): collation config (#439) * refactor(mainnet): add pallet_authorship to collation * test(mainnet): add pallet_auhtorship test * refactor(mainnet): add pallet_aura to collation * test(mainnet): add pallet_aura tests * refactor(mainnet): add collator_selection to collation * test(mainnet): add collator_selection tests * refactor(mainnet): add pallet_session & aura_ext to collation * test(mainnet): add pallet_session tests * chore(aura): MaxAuthorities matches max possible blocks produced * remove unnused imports * style(collation): order tests following pallet config * style(collation): remove unnecessary qualifications * style(collation): max_authorities_is_3600 * style(collation): reorg definition in session_keys_provided_by_aura test * style(collation): better Period comment * style(collation): clarify session::SessionHandler comment * refactor(collation): separate tests in modules by pallet * style(collation): Explain SessionHandler config fixes after rebase * style(collation): remove prefixes from tests * style(collation): Period comment was not helpful changes after rebase * refactor(xcm): add pallet_message_queue into xcm config module * test(xcm): add message_queue tests * test(xcm): test location, transactor and barrier type definitions * refactor(xcm): include pallet_xcmp_queue into xcm config module * test(xcm): add pallet_xcmp_queue configuration tests * test(xcm): add xcm_executor configuration tests * test(xcm): adding pallet_xcm config tests * fix(xcm): typo fix(xcm): XcmReserveTransferFilter is Everything * refactor(xcm): use unitype for MaxRemoteLockConsumers * style(xcm): tests separated in modules * style(xcm): better naming for XcmTeleportFilter test * style(xcm): test naming and order * docs(xcm): clarifying comments for specific xcmp_queueu types * style(xcm): typo * style(xcm): better name for reserves tests * refactor(xcm): Use `NativeAssetFrom<T>` as `XcmReserveTransferFilter` (#459) * refactor(xcm): Use NativeAssetFrom<T> as XcmReserveTransferFilter style:fmt * fix(xcm): NativeAssetFrom<AssetHub> filters everything but DOT from AH * fix(xcm): XcmReserveTransferFilter filters only by asset fix changes after rebase fmt * fix(xcm): remove waived locations (#456) * fix(xcm): no locations are waived * test(xcm): improved waived_location test changes after rebase * style(xcm): clarify that we are not waiving fees for any location * fix(xcm): charge delivery fees (#457) * resolve rebase conflicts * fix(xcm): reserve_transfer_native_asset_from_para_to_system_para accounts for delivery fees * fix(integration-tests): handle delivery_fees only with mainnet feature on fmt after rebase fmt changes after rebase fmt fmt * test(xcm): address feedback from #459 typos AssetFilter * style(xcm): locate reserve tests within executor lint * fix(integration-test): improve tests & remove feature gated compilation unnecessary Fungibles * refactor: integration tests mainnet xcm (#466) * refactor: integration tests mainnet xcm * fix: remove unused ED rebase fmt fmt * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * refactor(xcm): use TreasuryAccount from monetary * chore(xcm): unused imports * chore(xcm): amend test modules * chore(integration-tests): amend reserve_transfer_native_asset_from_para_to_system * chore(xcm): divive reserve filter test in two * chore(xcm): fmt * style(integration-tests): fix unwanted indentation * test(xcm): more focused unit tests * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> * fix(test): amend suggestions --------- Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

al3mart force-pushed the al3mart/refactor-mainnet-config branch 3 times, most recently from 7359e7a to 9594a3b Compare January 24, 2025 17:20

al3mart force-pushed the al3mart/refactor-mainnet-system branch from 35458a3 to 7efb58e Compare January 27, 2025 21:52

al3mart commented Jan 30, 2025

View reviewed changes

al3mart requested review from Daanvdplas and peterwht January 30, 2025 23:50

al3mart marked this pull request as ready for review January 30, 2025 23:50

al3mart mentioned this pull request Jan 31, 2025

refactor(mainnet): ready runtime config #458

Merged

11 tasks

al3mart added the ready-for-final-review label Jan 31, 2025

Daanvdplas reviewed Feb 3, 2025

View reviewed changes

runtime/mainnet/src/config/mod.rs Show resolved Hide resolved

Daanvdplas reviewed Feb 3, 2025

View reviewed changes

runtime/mainnet/src/config/system.rs Outdated Show resolved Hide resolved

al3mart requested a review from Daanvdplas February 3, 2025 17:47

Daanvdplas requested changes Feb 3, 2025

View reviewed changes

al3mart requested a review from Daanvdplas February 4, 2025 11:30

al3mart added 13 commits February 4, 2025 12:43

refactor(mainnet): add frame_system to system

37d241f

test(mainnet): add pallet_system test

126ac05

fix(mainnet): rebase fixes

993befd

fix(system): bring missing types in scope

80b5ae4

refactor(system): add cumulus_parachain_system to system config module

bf4a2c4

test(system): add cumulus_parachain_system tests

f320033

refactor(system): add parachain_info into system config module

afefb51

refactor(system): add pallet_timestamp into system config module

5cded3f

style(system): add ConsensusHook comment

ed805d0

refactor(system): separate tests by module

5be163f

docs(system): document public config modules

3a48998

fix(system): allow unused_imports to remove Executive warning

f95c977

refactor(system): reintroduce FilteredCalls

ceaa7b6

al3mart added 4 commits February 4, 2025 12:44

style(system): get rid of test prefixes

f0bf920

style(system): relocate max_block_weigth comment

8cc1611

test(system): check for Hash type config

b02ba50

docs(system): amend outdated comments

54cc880

al3mart force-pushed the al3mart/refactor-mainnet-system branch from 003efa0 to 54cc880 Compare February 4, 2025 11:44

Daanvdplas approved these changes Feb 4, 2025

View reviewed changes

runtime/mainnet/src/config/mod.rs Outdated Show resolved Hide resolved

runtime/mainnet/src/config/mod.rs Outdated Show resolved Hide resolved

runtime/mainnet/src/config/mod.rs Outdated Show resolved Hide resolved

runtime/mainnet/src/config/mod.rs Outdated Show resolved Hide resolved

al3mart and others added 4 commits February 4, 2025 17:36

Update runtime/mainnet/src/config/mod.rs

ca8cb6f

Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

Update runtime/mainnet/src/config/mod.rs

6f411b9

Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

Update runtime/mainnet/src/config/mod.rs

59c4330

Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

Update runtime/mainnet/src/config/mod.rs

6eb1ecc

Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>

al3mart merged commit e866970 into al3mart/refactor-mainnet-config Feb 4, 2025
3 checks passed

al3mart deleted the al3mart/refactor-mainnet-system branch February 4, 2025 16:36

Conversation

al3mart commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

al3mart Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

al3mart Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Daanvdplas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Daanvdplas Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

al3mart Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Daanvdplas Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

al3mart Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Daanvdplas Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

al3mart commented Feb 4, 2025

Uh oh!

Daanvdplas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

al3mart commented Jan 21, 2025 •

edited

Loading

codecov-commenter commented Jan 30, 2025 •

edited

Loading

al3mart Feb 4, 2025 •

edited

Loading