Skip to content

chore: upgrade to 2503 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexD10S merged 7 commits into from
Jun 20, 2025

chore: format

3b2c03f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore: upgrade to 2503 #58

chore: format
3b2c03f
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jun 10, 2025 in 0s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.86.0 (05f9846f8 2025-03-31)
  • cargo 1.86.0 (adf9b6ad1 2025-02-28)
  • clippy 0.1.86 (05f9846f89 2025-03-31)

Annotations

Check warning on line 271 in runtime/src/apis.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-local `impl` definition, `impl` blocks should be written at the same level as their item 

warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item
   --> runtime/src/apis.rs:271:13
    |
252 | /         fn dispatch_benchmark(
253 | |             config: frame_benchmarking::BenchmarkConfig
254 | |         ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, alloc::string::String> {
    | |___________________________________________________________________________________- move the `impl` block outside of this associated function `dispatch_benchmark`
...
271 |               impl cumulus_pallet_session_benchmarking::Config for Runtime {}
    |               ^^^^^-------------------------------------------^^^^^-------
    |                    |                                               |
    |                    |                                               `Runtime` is not local
    |                    `Config` is not local
    |
    = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`

Check warning on line 259 in runtime/src/apis.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-local `impl` definition, `impl` blocks should be written at the same level as their item 

warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item
   --> runtime/src/apis.rs:259:13
    |
252 | /         fn dispatch_benchmark(
253 | |             config: frame_benchmarking::BenchmarkConfig
254 | |         ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, alloc::string::String> {
    | |___________________________________________________________________________________- move the `impl` block outside of this associated function `dispatch_benchmark`
...
259 |               impl frame_system_benchmarking::Config for Runtime {
    |               ^^^^^---------------------------------^^^^^-------
    |                    |                                     |
    |                    |                                     `Runtime` is not local
    |                    `Config` is not local
    |
    = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`
    = note: `#[warn(non_local_definitions)]` on by default
View more details on GitHub Actions