Conversation
AlexD10S
commented
Jun 10, 2025
chungquantin
suggested changes
Jun 16, 2025
Contributor
chungquantin
left a comment
chungquantin
left a comment
There was a problem hiding this comment.
Looks great overall, left a few suggestions. Happy to approve after those are resolved.
Not related this parachain template but I saw that template for pallets also include the view function changes. Any plan to update our template for pallet to include this as well?
11 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uplift
base-parachaintemplate to stable2503 - Release Changelog.Used the
pop-nodeuplift as reference: r0gue-io/pop-node#514Relevant PRs
Edit after feedback
[sc-3868]