Skip to content

Update minimum Python version to 3.7.2 #6926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datumbox merged 2 commits into from
Nov 9, 2022
Merged

Update minimum Python version to 3.7.2 #6926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cdcd41
Update minimum version to 3.7.2
datumbox Nov 8, 2022
960f211
Merge branch 'main' into docs/update_py_ver
datumbox Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ supported Python versions.
+--------------------------+--------------------------+---------------------------------+
| ``torch`` | ``torchvision`` | ``python`` |
+==========================+==========================+=================================+
| ``main`` / ``nightly`` | ``main`` / ``nightly`` | ``>=3.7``, ``<=3.10`` |
| ``main`` / ``nightly`` | ``main`` / ``nightly`` | ``>=3.7.2``, ``<=3.10`` |
+--------------------------+--------------------------+---------------------------------+
| ``1.13.0`` | ``0.14.0`` | ``>=3.7``, ``<=3.10`` |
| ``1.13.0`` | ``0.14.0`` | ``>=3.7.2``, ``<=3.10`` |
Copy link
Member

@NicolasHug NicolasHug Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @datumbox . Are we planning on a bugfix release soon? Otherwise it might be more accurate to leave this line untouched (and update the X in 0.14.X)

Copy link
Contributor Author

@datumbox datumbox Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware of any bugfix releases any time soon. I think we should update the table to reflect that 3.7.0 won't work.

+--------------------------+--------------------------+---------------------------------+
| ``1.12.0`` | ``0.13.0`` | ``>=3.7``, ``<=3.10`` |
+--------------------------+--------------------------+---------------------------------+
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ def run(self):
"scipy": ["scipy"],
},
ext_modules=get_extensions(),
python_requires=">=3.7",
python_requires=">=3.7.2",
Copy link
Member

@NicolasHug NicolasHug Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I commented on #6925 (comment), I think there might be a more robust and future-proof way of handling the original failure.

I'm also wondering if it's safe for us to deviate from torch core's Python version requirements which seem to be set to 3.7.0 as well:

https://github.com/pytorch/pytorch/blob/8cb5c5543e92628782deb00dda78380076b89e66/setup.py#L214

@malfet could you please advise on this?

cmdclass={
"build_ext": BuildExtension.with_options(no_python_abi_suffix=True),
"clean": clean,
Expand Down